Premint api helper #276
Merged
Premint api helper #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
iainnash
commented
Oct 18, 2023
•
iainnash
commented
- Remove preminter code from 1155 contracts
- Add a new SDK for preminting to packages
- Cleanup dependencies for 1155 contracts
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…nto prerelease_premint_api_helper
iainnash
force-pushed
the
prerelease_premint_api_helper
branch
from
03abe58 to
a4fb8b0
Compare
iainnash
force-pushed
the
prerelease_premint_api_helper
branch
from
aa1fe8c to
aa023d3
Compare
iainnash
force-pushed
the
prerelease_premint_api_helper
branch
from
fa29600 to
1863881
Compare
oveddan
reviewed
Oct 24, 2023
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mattlenz
reviewed
Oct 24, 2023
margalit
reviewed
Oct 24, 2023
margalit
reviewed
Oct 24, 2023
kolber
approved these changes
Oct 25, 2023
| maxTokensPerAddress?: bigint; | ||
| pricePerToken?: bigint; | ||
| mintStart?: bigint; | ||
| mintDuration?: bigint; |
There was a problem hiding this comment.
We've added a local validation here to ensure it's not accidentally sent in ms (very common mistake). Might be nice here too if we can find a way to do it.
| }); | ||
| } | ||
|
|
||
| const ZORA_API_BASE = "https://api.zora.co/premint/"; |
There was a problem hiding this comment.
Have we thought about how we'll handle v1/v2 versions of premint? Will the API still stay the same?
There was a problem hiding this comment.
We probably will need to handle different messages coming back from the server transparently.
…nto prerelease_premint_api_helper
oveddan
approved these changes
Oct 26, 2023
oveddan
reviewed
Oct 26, 2023
packages/premint-sdk/package.json
Outdated
| "anvil": "source .env.anvil && anvil --fork-url $FORK_RPC_URL --fork-block-number $FORK_BLOCK_NUMBER --chain-id 31337" | ||
| }, | ||
| "dependencies": { | ||
| "@zoralabs/zora-1155-contracts": "2.1.1-premint-api.0", |
There was a problem hiding this comment.
this should be:
"@zoralabs/zora-1155-contracts": "*"
There was a problem hiding this comment.
Changesets changes this on release.
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Oct 26, 2023
Merged
oveddan
reviewed
Oct 30, 2023
| "@zoralabs/premint-sdk": minor | ||
| --- | ||
|
|
||
| Added new premint api that abstracts out calls to the chain signature and submission logic around submitting a premint. This change also incorporates test helpers for premints and introduces docs and an api client for the zora api's premint module. |
oveddan
reviewed
Oct 30, 2023
iainnash
added a commit
that referenced
this pull request
Jan 11, 2024
* Remove preminter code from 1155 contracts * Add a new SDK for preminting to packages * Cleanup dependencies for 1155 contracts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.