Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Premint api helper - fix build for 1155 by getting rid of prepack and just fixing the build step #308

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Premint api helper - fix build for 1155 by getting rid of prepack and just fixing the build step #308

merged 2 commits into from
Oct 30, 2023

Conversation

oveddan
Copy link
Collaborator

@oveddan oveddan commented Oct 30, 2023 •
edited
Loading

  • fix monorepo build by removing prepack step from 1155 and always include it in "build"
  • do not run premint-sdk tests in CI, since they require anvil to run

@oveddan
Copy link
Collaborator Author

oveddan commented Oct 30, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@oveddan oveddan mentioned this pull request Oct 30, 2023
Merged
@iainnash
Copy link
Collaborator

iainnash commented Oct 30, 2023 •
edited
Loading

Merge activity

  • Oct 30, 6:36 PM: @iainnash started a stack merge that includes this pull request via Graphite.
  • Oct 30, 6:37 PM: Graphite rebased this pull request as part of a merge.
  • Oct 30, 6:39 PM: @iainnash merged this pull request with Graphite.

@iainnash iainnash changed the base branch from prerelease_premint_api_helper to main October 30, 2023 22:36
@iainnash iainnash force-pushed the premint-api-helper-fix-build branch from e2fa64d to e01064f Compare October 30, 2023 22:37
@iainnash iainnash merged commit 1a2c92a into main Oct 30, 2023
iainnash pushed a commit that referenced this pull request Jan 11, 2024
@oveddan
Premint api helper - fix build for 1155 by getting rid of prepack and…
2e3f8ab 
… just fixing the build step (#308)

* fix monorepo build by removing prepack step from 1155 and always include it in "build"
* do not run premint-sdk tests in CI, since they require anvil to run
@iainnash iainnash deleted the premint-api-helper-fix-build branch January 11, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iainnash iainnash iainnash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oveddan @iainnash