Skip to content
This repository was archived by the owner on Dec 23, 2019. It is now read-only.

fix(telephony.line.phone.programmablekeys): keys natural sort #1510

Conversation

julieni
Copy link
Contributor

@julieni julieni commented Sep 3, 2019

Telephony line phone programmable keys : natural sort order

Description of the Change

Keys are now sorted in natural order

@JeremyDec
Copy link
Contributor

Hello @julieni, thanks for your contribution !

We will take in charge your fix, and keep you in touch once it will be applied

@julieni
Copy link
Contributor Author

julieni commented Sep 4, 2019

Hello @JeremyDec, I saw your changes in ovh/manager#1268, thanks for improvements ;)
BTW, should we submit PR in repo https://github.com/ovh-ux/manager or separate repos ?

@JeremyDec
Copy link
Contributor

Hello, for the telecom part of the manager, you should submit PR into the new repo => https://github.com/ovh-ux/manager.

If the part you want to change/fix is not present in this repository, you can make your PR in the https://github.com/ovh-ux/ovh-manager-xxxxx one.

You're welcome :)

@jleveugle
Copy link
Contributor

Hello @julieni,
Your pull request is now closed due to inactivity.
Feel free to re-open it if you have any update.
Anna Bot for OVH UX <3

@jleveugle jleveugle closed this Sep 13, 2019
@julieni
Copy link
Contributor Author

julieni commented Sep 13, 2019

Hi,
as this PR is closed, it seems it's replaced by ovh/manager#1268, also closed now, and then #1512 which is still open.
But still no merge in develop or master, and no push in production.
OVH team, do you have an ETA for this patch to land in production ? Thanks.

@antleblanc antleblanc reopened this Sep 17, 2019
@antleblanc
Copy link
Contributor

antleblanc commented Sep 17, 2019

Hi @julieni!

Thanks for submitting this Pull request.

As @JeremyDec said, we are in fact trying to move this repository into another one that will group all applications that rely on the Control Panel. But we are still working on it that's why we need to do some extra synchronization actions (replicate your fix into our monorepo).

I send your patch to our Quality Check Team to get a feedback in order to be able to merge it.

I will keep you posted, Thanks!

Edit:

Internal ticket reference: MANAGER-3242

@antleblanc
Copy link
Contributor

@julieni I was notified by @euhmeuh that your fix has been picked and improved in this following Pull request: #1512 (we kept your commit.)

So I close this pull request.

Thanks again for your contribution. I will keep you posted as soon as the fix is deployed.

Thanks!

@antleblanc antleblanc closed this Sep 17, 2019
antleblanc added a commit that referenced this pull request Sep 18, 2019
@antleblanc
Copy link
Contributor

@julieni Patch has been deployed.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

4 participants