This repository was archived by the owner on Dec 23, 2019. It is now read-only.
fix(telephony.phone): fix order of function keys #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euhmeuh
requested review from
antleblanc,
AxelPeter,
cbourgois,
FredericEspiau,
frenautvh,
ganeshkumar1989,
JeremyDec,
Jisay,
jleveugle,
marie-j,
radireddy and
varun257
as code owners
FredericEspiau
previously approved these changes
Sep 5, 2019
JeremyDec
previously approved these changes
Sep 5, 2019
euhmeuh
dismissed stale reviews from JeremyDec and FredericEspiau
via
3d48a24
euhmeuh
force-pushed
the
fix/line-phone-keys-sort
branch
from
b2f0cf1 to
3d48a24
Compare
JeremyDec
previously approved these changes
Sep 6, 2019
frenautvh
reviewed
Sep 6, 2019
...hony/line/phone/programmableKeys/telecom-telephony-line-phone-programmableKeys.controller.js
Outdated
Show resolved
Hide resolved
JeremyDec
force-pushed
the
fix/line-phone-keys-sort
branch
from
3d48a24 to
e43376e
Compare
euhmeuh
force-pushed
the
fix/line-phone-keys-sort
branch
from
e43376e to
06b374b
Compare
frenautvh
previously approved these changes
Sep 6, 2019
Co-authored-by: euhmeuh <[email protected]> Co-authored-by: julieni <[email protected]>
JeremyDec
force-pushed
the
fix/line-phone-keys-sort
branch
from
06b374b to
a4e5642
Compare
antleblanc
approved these changes
Sep 17, 2019
Merged
|
thanks @antleblanc and @JeremyDec |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of ovh/manager#1268
fix #1510
ref: MANAGER-3242