Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pci-databases-analytics): format prices and us regions #13273

Merged
merged 8 commits into from
Oct 17, 2024
Merged

fix(pci-databases-analytics): format prices and us regions #13273

merged 8 commits into from
Oct 17, 2024

Conversation

jperchoc
Copy link
Contributor

@jperchoc jperchoc commented Sep 25, 2024 •
edited by abullet33
Loading

Question Answer
Branch? cleanup-pci-databases-analytics
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #DATATR-1497, DATATR-1481, DATATR-1517, DATATR-1479, DATATR-1506, DATATR-1439, DATATR-1450, DATATR-1484, DATATR-1539
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

  • Correctly format prices with current language
  • Invalidate service query when updating
  • Add missing translations for US regions
  • Use unit provided by the api for the translations in metrics
  • Fix restore pop-up closing after validation
  • Add terminate input field to delete service
  • Fix skeleton size in dashboard
  • Display number of services in table
  • Display Public network information
  • Remove Regex in database name form

Related

  • CMT-17258

@jperchoc jperchoc requested review from a team as code owners September 25, 2024 15:39
@github-actions github-actions bot added translation required bug Something isn't working labels Sep 25, 2024
abullet33
abullet33 previously approved these changes Sep 25, 2024
View reviewed changes
@jperchoc jperchoc force-pushed the feat/cleanup-pci-database-analytics-app branch from ea3a13e to 6b2792f Compare September 26, 2024 15:50
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Sep 26, 2024
Base automatically changed from feat/cleanup-pci-database-analytics-app to release/public-cloud-w40 September 26, 2024 17:10
@jperchoc jperchoc force-pushed the fix/databases-cleanup-prices-us branch 2 times, most recently from b852f82 to 1112c3e Compare September 27, 2024 08:28
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Sep 27, 2024
Base automatically changed from release/public-cloud-w40 to master September 30, 2024 09:44
@antonymarion antonymarion dismissed abullet33’s stale review September 30, 2024 09:44

The base branch was changed.

ppprevost
ppprevost previously approved these changes Oct 15, 2024
View reviewed changes
anooparveti
anooparveti previously approved these changes Oct 15, 2024
View reviewed changes
abullet33
abullet33 previously approved these changes Oct 15, 2024
View reviewed changes
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Oct 17, 2024
jperchoc and others added 8 commits October 17, 2024 17:37
@jperchoc @abullet33
fix: use localisation to correctly format prices
37dae95 
ref: DATATR-1481
Signed-off-by: Jonathan Perchoc <[email protected]>
@jperchoc @abullet33
feat: add missing region translations for US
2ebe520 
ref: DATATR-1481
Signed-off-by: Jonathan Perchoc <[email protected]>
@jperchoc @abullet33
fix: invalidate services list query on update
3ea12ba 
ref: DATATR-1497
Signed-off-by: Jonathan Perchoc <[email protected]>
@jperchoc @abullet33
fix: translate the unit provided by the api for the metrics (#13341)
133a3cd 
ref: DATATR-1517

Signed-off-by: Jonathan Perchoc <[email protected]>
@abullet33
Fix/databases restore pop up not working well (#13506)
8eeba07 
* fix(pci-databases-analytics): dashboard rework
ref:datatr-1479, datatr-1506

* fix(pci-databases-analytics): restore pop-up fixes
ref:datatr-1439

* fix(pci-databases-analytics): add terminate button for service deletion
ref:datatr-1450

* fix(pci-databases-analytics): display number of services result
ref:datatr-1484

Signed-off-by: Arthur Bullet <[email protected]>
@abullet33
fix(pci-databases-analytics): remove name regex in database form
056cc64 
ref:datatr-1539
Signed-off-by: Arthur Bullet <[email protected]>
@abullet33
feat(pci-databases-analytics): fix pr comments
98c4f26 
Signed-off-by: Arthur Bullet <[email protected]>
@abullet33
fix(pci-databases-analytics): merge translation file
3aea5b6 
Signed-off-by: Arthur Bullet <[email protected]>
@abullet33 abullet33 dismissed stale reviews from anooparveti, ppprevost, and themself via 3aea5b6 October 17, 2024 15:38
@abullet33 abullet33 force-pushed the fix/databases-cleanup-prices-us branch from 05f671b to 3aea5b6 Compare October 17, 2024 15:38
@github-actions github-actions bot added translation required and removed has conflicts Has conflicts to resolve before merging labels Oct 17, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
19.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@anooparveti anooparveti changed the base branch from master to release/public-cloud-w43 October 17, 2024 15:44
@anooparveti anooparveti merged commit c52780a into release/public-cloud-w43 Oct 17, 2024
11 of 15 checks passed
@anooparveti anooparveti deleted the fix/databases-cleanup-prices-us branch October 17, 2024 15:45
@anooparveti anooparveti mentioned this pull request Oct 17, 2024
Merged
13 tasks
anooparveti pushed a commit that referenced this pull request Oct 17, 2024
@jperchoc @abullet33 @anooparveti
fix(pci-databases-analytics): us regions and bug fixes (#13273)
5f0bc21 
Use localisation to correctly format prices
add missing region translations for US
invalidate services list query on update
translate the unit provided by the api for the metrics
restore pop up not working well
dashboard rework
restore pop-up fixes
add terminate button for service deletion
display number of services result
remove name regex in database form
ref: DATATR-1497, DATATR-1481, DATATR-1517, DATATR-1479, DATATR-1506, DATATR-1439, DATATR-1450, DATATR-1484, DATATR-1539

Signed-off-by: Jonathan Perchoc <[email protected]>
Co-authored-by: Arthur Bullet <[email protected]>
anooparveti pushed a commit that referenced this pull request Oct 22, 2024
@jperchoc @abullet33 @anooparveti
fix(pci-databases-analytics): us regions and bug fixes (#13273)
f79f55e 
Use localisation to correctly format prices
add missing region translations for US
invalidate services list query on update
translate the unit provided by the api for the metrics
restore pop up not working well
dashboard rework
restore pop-up fixes
add terminate button for service deletion
display number of services result
remove name regex in database form
ref: DATATR-1497, DATATR-1481, DATATR-1517, DATATR-1479, DATATR-1506, DATATR-1439, DATATR-1450, DATATR-1484, DATATR-1539

Signed-off-by: Jonathan Perchoc <[email protected]>
Co-authored-by: Arthur Bullet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abullet33 abullet33 abullet33 left review comments

@anooparveti anooparveti anooparveti left review comments

@ppprevost ppprevost ppprevost left review comments

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx was automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid was automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy was automatically assigned from ovh/team-manager-dev-angularjs

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion was automatically assigned from ovh/team-manager-dev-angularjs

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
bug Something isn't working quality check: ok translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jperchoc @ppprevost @anooparveti @abullet33