Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iam): add applications tab #13403

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

feat(iam): add applications tab #13403

wants to merge 3 commits into from

Conversation

rjamet-ovh
Copy link
Contributor

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #MANAGER-15410
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

IAM add applications tab

Related

@rjamet-ovh rjamet-ovh marked this pull request as ready for review October 7, 2024 08:35
@rjamet-ovh rjamet-ovh requested a review from a team as a code owner October 7, 2024 08:35
JacquesLarique
JacquesLarique previously approved these changes Oct 8, 2024
View reviewed changes
oalkabouss
oalkabouss previously approved these changes Oct 9, 2024
View reviewed changes
@rjamet-ovh
Copy link
Contributor Author

Hello @zZHorizonZz

Thank you for your contribution!
We're currently in the process of testing the app and managing translations and tracking.

We'll update this PR as soon as we progress on theses steps.

@zZHorizonZz
Copy link

@rjamet-ovh Hey, sorry for not responding to the reviews in #13396. Since I didn't create that pull request, I wasn't subscribed to it so I didn't get any notifications and was unaware that the review was happening there. From what I see, the main issue was with me adding English translations to the French files. I could have used a translator, but I don't know if they would be accurate with French, so I opted to keep the text in English.

@zZHorizonZz zZHorizonZz mentioned this pull request Oct 29, 2024
Open
8 tasks
zZHorizonZz and others added 3 commits November 14, 2024 18:09
@zZHorizonZz
feat(iam): add applications tab (#13396)
bdf5c49 
Signed-off-by: Daniel Fiala <[email protected]>
fix(iam): update application tab translations
c8cb9a1 
ref: MANAGER-15410

Signed-off-by: Romain Jamet <[email protected]>
fix(iam): fix application tracking constants
0f04b8a 
ref: MANAGER-15410

Signed-off-by: Romain Jamet <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 14, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacquesLarique JacquesLarique JacquesLarique left review comments

@oalkabouss oalkabouss oalkabouss left review comments

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn sachinrameshn is a code owner automatically assigned from ovh/team-manager-dev-angularjs

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rjamet-ovh @zZHorizonZz @oalkabouss @JacquesLarique