-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add fetching grapher configs by UUID #3879
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-08-19 15:14:23 UTC |
d868f99
to
df600ae
Compare
28327df
to
e5c06a1
Compare
df600ae
to
8a2e4a8
Compare
e5c06a1
to
57c64eb
Compare
8a2e4a8
to
f18b0d2
Compare
8d270f1
to
7c74a5b
Compare
540fafb
to
0c656d4
Compare
7c74a5b
to
1c77908
Compare
0c656d4
to
484bd0d
Compare
29146e2
to
9e8ac98
Compare
9e8ac98
to
30eb978
Compare
afa702d
to
9b7ba3d
Compare
30eb978
to
9a5e0e5
Compare
9b7ba3d
to
af2f857
Compare
9a5e0e5
to
ac04f5c
Compare
This was referenced Aug 26, 2024
ecffac1
to
2b761ca
Compare
0b7eadc
to
39b26de
Compare
2b761ca
to
ade6496
Compare
39b26de
to
b837314
Compare
ade6496
to
a8553c5
Compare
b837314
to
dd90777
Compare
a8553c5
to
563e74b
Compare
dd90777
to
54273d0
Compare
563e74b
to
275fa56
Compare
54273d0
to
7e42ffd
Compare
275fa56
to
c902103
Compare
7e42ffd
to
de9ef7a
Compare
c902103
to
b0cd9d5
Compare
de9ef7a
to
02ef8d3
Compare
b0cd9d5
to
2f44d84
Compare
02ef8d3
to
9088888
Compare
2f44d84
to
3589dce
Compare
9088888
to
5538fc3
Compare
3589dce
to
d25b1ef
Compare
5538fc3
to
77b8e58
Compare
77b8e58
to
d8b5bc0
Compare
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds fetching of grapher configs from R2 via a CF function by using grapher config UUIDs instead of slugs. Because we have UUIDs for all chart configs (e.g. the ones defined in the ETL grapher config layer) we can get them for charts other than standalone charts that are published (which are the only ones that have valid, unique urls)