Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Use grapher config from API instead of from HTML in multiembedder #3884

Merged
merged 1 commit into from
Sep 10, 2024
Merged

✨ Use grapher config from API instead of from HTML in multiembedder #3884

merged 1 commit into from
Sep 10, 2024
+39 −4

Conversation

danyx23
Copy link
Contributor

@danyx23 danyx23 commented Aug 19, 2024 •
edited
Loading

This PR switches the multi-embedder from using the chart config in the HTML file to the explicit grapher API.

The current (draft) version just uses the same url as the request came in on but that means that for local dev you need to have baked pages to use port :8788. It's probably nicer to have an explicit "grapher api url" setting that defaults to the same as the main page for prod but can be set differently for local dev or staging

This was referenced Aug 19, 2024
Merged
Merged
@danyx23 Graphite App
Copy link
Contributor Author

danyx23 commented Aug 19, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @danyx23 and the rest of your teammates on Graphite Graphite

@danyx23 danyx23 force-pushed the render-thumbnails-by-uuid branch from 265637f to 91f193d Compare August 21, 2024 10:17
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 7ff4c04 to 718d193 Compare August 21, 2024 10:17
@danyx23 danyx23 force-pushed the render-thumbnails-by-uuid branch from 91f193d to 41b9260 Compare August 21, 2024 11:03
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 718d193 to 9575cd4 Compare August 21, 2024 11:03
@danyx23 danyx23 force-pushed the render-thumbnails-by-uuid branch from 41b9260 to 1dd7bdb Compare August 21, 2024 12:54
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 9575cd4 to df54d29 Compare August 21, 2024 12:54
@danyx23 danyx23 force-pushed the render-thumbnails-by-uuid branch from 1dd7bdb to 019831b Compare August 21, 2024 15:09
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from df54d29 to 31783c0 Compare August 21, 2024 15:09
@danyx23 danyx23 force-pushed the render-thumbnails-by-uuid branch from 019831b to b96dde4 Compare August 21, 2024 15:17
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 31783c0 to 4969cea Compare August 21, 2024 15:18
@danyx23 danyx23 force-pushed the render-thumbnails-by-uuid branch from b96dde4 to 9490433 Compare August 22, 2024 15:53
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 4969cea to 935fde8 Compare August 22, 2024 15:53
@danyx23 danyx23 mentioned this pull request Aug 22, 2024
Merged
@danyx23 danyx23 force-pushed the render-thumbnails-by-uuid branch from 9490433 to 6d5c3bc Compare August 22, 2024 15:56
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 935fde8 to daf3747 Compare August 22, 2024 15:56
@danyx23 danyx23 force-pushed the render-thumbnails-by-uuid branch from 6d5c3bc to b6d10f1 Compare August 22, 2024 17:12
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from daf3747 to efe49d6 Compare August 22, 2024 17:12
@danyx23 danyx23 force-pushed the render-thumbnails-by-uuid branch from b6d10f1 to 6189190 Compare August 23, 2024 11:21
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from efe49d6 to a6efc86 Compare August 23, 2024 11:21
@danyx23 danyx23 force-pushed the render-thumbnails-by-uuid branch from 6189190 to 845c2ab Compare August 26, 2024 20:46
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from a6efc86 to 4f6ed11 Compare August 26, 2024 20:46
This was referenced Aug 26, 2024
Draft
Merged
@danyx23 danyx23 requested a review from marcelgerber August 28, 2024 15:16
@danyx23 danyx23 marked this pull request as ready for review August 28, 2024 15:18
@danyx23 danyx23 force-pushed the render-thumbnails-by-uuid branch from 845c2ab to 26e490c Compare August 28, 2024 15:50
@danyx23 danyx23 force-pushed the render-thumbnails-by-uuid branch from 940738b to 0df5bff Compare September 9, 2024 14:45
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from e5338b6 to 8f4418c Compare September 9, 2024 14:46
@danyx23 danyx23 force-pushed the render-thumbnails-by-uuid branch from 0df5bff to 2a74086 Compare September 10, 2024 07:59
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 8f4418c to 6ea8ff0 Compare September 10, 2024 07:59
@danyx23 danyx23 force-pushed the render-thumbnails-by-uuid branch from 2a74086 to fa93186 Compare September 10, 2024 08:06
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 6ea8ff0 to 14065aa Compare September 10, 2024 08:06
@danyx23 danyx23 force-pushed the render-thumbnails-by-uuid branch from fa93186 to 8152321 Compare September 10, 2024 09:56
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 14065aa to 25404f1 Compare September 10, 2024 09:56
@danyx23 danyx23 force-pushed the render-thumbnails-by-uuid branch from 8152321 to 2163513 Compare September 10, 2024 10:24
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 25404f1 to 53ab64b Compare September 10, 2024 10:24
@danyx23 danyx23 force-pushed the render-thumbnails-by-uuid branch from 2163513 to dd56e2b Compare September 10, 2024 10:35
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 53ab64b to 35deed4 Compare September 10, 2024 10:35
@danyx23 danyx23 force-pushed the render-thumbnails-by-uuid branch from dd56e2b to eb1de29 Compare September 10, 2024 10:55
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 35deed4 to 4c94b5a Compare September 10, 2024 10:56
@danyx23 danyx23 force-pushed the render-thumbnails-by-uuid branch from eb1de29 to 380b1f5 Compare September 10, 2024 11:15
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 4c94b5a to 18dd056 Compare September 10, 2024 11:16
@danyx23 danyx23 force-pushed the render-thumbnails-by-uuid branch 2 times, most recently from 02cf775 to 2689b72 Compare September 10, 2024 11:31
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 18dd056 to 868a5f7 Compare September 10, 2024 11:31
@danyx23 danyx23 changed the base branch from render-thumbnails-by-uuid to graphite-base/3884 September 10, 2024 11:47
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 868a5f7 to caecd68 Compare September 10, 2024 11:48
@danyx23 danyx23 changed the base branch from graphite-base/3884 to master September 10, 2024 11:48
@danyx23
✨ Use grapher config from API instead of from HTML in multiembedder.
d728828 
Also adds two new mockSiteRouter routes so that
in local dev we can fetch grapher configs from the
DB instead of R2 via the admin API
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from caecd68 to d728828 Compare September 10, 2024 11:48
@danyx23 Graphite App
Copy link
Contributor Author

danyx23 commented Sep 10, 2024 •
edited
Loading

Merge activity

  • Sep 10, 8:00 AM EDT: @danyx23 started a stack merge that includes this pull request via Graphite.
  • Sep 10, 8:01 AM EDT: @danyx23 merged this pull request with Graphite.

@danyx23 danyx23 merged commit 036fc1d into master Sep 10, 2024
19 of 21 checks passed
@danyx23 danyx23 deleted the multiembedder-use-config-api branch September 10, 2024 12:01
This was referenced Oct 4, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelgerber marcelgerber marcelgerber left review comments

Assignees

@danyx23 danyx23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danyx23 @marcelgerber