-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 support entity exclusion for all chart types #4583
Conversation
336c912
to
0f0f725
Compare
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2025-02-26 11:09:54 UTC |
3dcae7a
to
effd297
Compare
@@ -865,7 +865,7 @@ export class Grapher | |||
// (2) needs to have data for the x and y dimension. | |||
let table = this.isScatter | |||
? this.tableAfterAuthorTimelineAndActiveChartTransform | |||
: this.inputTable | |||
: this.table |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since table
is the cleaned inputTable
that we actually want to use as a base table for Grapher, I think it makes sense to use it for the entity selector as well.
f8b9d8c
to
079935c
Compare
effd297
to
403876a
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
403876a
to
72228a4
Compare
079935c
to
f75b87d
Compare
72228a4
to
86cbd16
Compare
86cbd16
to
bc428b6
Compare
bc428b6
to
29ef92e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
and yeah, I agree on changing the basis for tableForSelection
, makes sense.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Allows to exclude entities for all chart types (used to be supported for Scatter and Marimekko only).
Entity exclusion is similar to the author's timeline filter in the sense that it should seem like the excluded entities simply don't exist, so the entity exclusion runs as early as the author timeline filter.