🔨 remove availableEntities from SelectionArray

[sophiamersmann]

I tripped over the availableEntities of Grapher's selection in the last PR and wondered if it makes sense for the SelectionArray to manage both, the selected and the available entities.

I don't have a strong opinion but I am in slight favour of removing the available entities from the SelectionArray. I don't see a compelling reason for them to be part of the SelectionArray interface, and the fact that the available entities need to be kept up-to-date is a potential foot gun.

I also wonder if we could unify SelectionArray and FocusArray now that both essentially do the same thing (manage a selection).

Feel free to stop me – again, no strong opinion from my side.

[sophiamersmann]

• 🔨 remove availableEntities from SelectionArray #4591 👈 (View in Graphite)
• 🎉 support entity exclusion for all chart types #4583
• 🔨 migrate excludedEntities and includedEntities to use entity names instead of ids #4582
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[owidbot]

Quick links (staging server):

Site Dev	Site Preview	Admin	Wizard	Docs

Login: ssh owid@staging-site-remove-available-entities

• Site-screenshots: https://github.com/owid/site-screenshots/compare/remove-available-entities
• SVG tester: https://github.com/owid/owid-grapher-svgs/compare/remove-available-entities

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2025-02-26 11:35:03 UTC
Execution time: 1.28 seconds

[marcelgerber]

nice cleanup!

I tested this

• on a standalone grapher page ✅
• on a country page with the global entity selector ✅
• on an explorer page ✅
  • but for the explorer, I noticed that the previous change to the construction of availableEntityNames actually changed the behavior, and that the old behavior had some merit there. I'll put up a PR in which I explain this further: enhance(explorer): use append-only availableEntityNames #4610

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ RangeError: Out of memory FilterMask.apply(packages/@ourworldindata/core-... View Issue
• ‼️ RangeError: Out of memory get AbstractCoreColumn.validRowIndices(packages... View Issue
• ‼️ RangeError: Out of memory FilterMask.apply(packages/@ourworldindata/core-... View Issue
• ‼️ RangeError: Out of memory get AbstractCoreColumn.validRowIndices(packages... View Issue
• ‼️ Error: [mobx] Cycle detected in computation [email protected]: get availableEntities(){return this.tableForSelection.availableEntities} get Grapher.numSelectableEntityNames(packages/@... View Issue

_{Did you find this useful? React with a 👍 or 👎}