Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ast/estree): use #[estree(append_to)] for TSModuleBlock #9020

Merged
merged 1 commit into from
Feb 10, 2025
Merged

fix(ast/estree): use #[estree(append_to)] for TSModuleBlock #9020

merged 1 commit into from
Feb 10, 2025
+17 −52

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Feb 10, 2025 •
edited
Loading

Replace custom Serialize impl for TSModuleBlock by using #[estree(append_to)] instead. This also fixes the TS type def for TSModuleBlock.

@github-actions github-actions bot added A-ast Area - AST C-bug Category - Bug labels Feb 10, 2025
@overlookmotel overlookmotel mentioned this pull request Feb 10, 2025
Merged
@overlookmotel Graphite App
Copy link
Contributor Author

overlookmotel commented Feb 10, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel mentioned this pull request Feb 10, 2025
Merged
@overlookmotel overlookmotel marked this pull request as ready for review February 10, 2025 16:26
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 10, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9020 will not alter performance

Comparing 02-10-fix_ast_estree_use_estree_append_to_for_tsmoduleblock_ (9427007) with main (8db4727)

Summary

✅ 33 untouched benchmarks

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Feb 10, 2025
@overlookmotel Graphite App
Copy link
Contributor Author

overlookmotel commented Feb 10, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Feb 10, 11:37 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 10, 11:37 AM EST: A user added this pull request to the Graphite merge queue.
  • Feb 10, 11:43 AM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #9019.
  • Feb 10, 11:43 AM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #9019.
  • Feb 10, 12:48 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 10, 12:48 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 10, 12:55 PM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 10, 2025
@overlookmotel overlookmotel force-pushed the 02-10-fix_ast_estree_use_estree_append_to_for_tsmoduleblock_ branch from f31ab46 to f6fef1b Compare February 10, 2025 17:04
@overlookmotel overlookmotel force-pushed the 02-10-refactor_ast_estree_re-arrange_and_comment_custom_serialization_code branch from 3cd4374 to dd717d8 Compare February 10, 2025 17:04
@overlookmotel overlookmotel mentioned this pull request Feb 10, 2025
Merged
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Feb 10, 2025
@overlookmotel
fix(ast/estree): use #[estree(append_to)] for TSModuleBlock (#9020)
9427007 
Replace custom `Serialize` impl for `TSModuleBlock` by using `#[estree(append_to)]` instead. This also fixes the TS type def for `TSModuleBlock`.
@graphite-app graphite-app bot force-pushed the 02-10-refactor_ast_estree_re-arrange_and_comment_custom_serialization_code branch from dd717d8 to eef8874 Compare February 10, 2025 17:49
@graphite-app graphite-app bot force-pushed the 02-10-fix_ast_estree_use_estree_append_to_for_tsmoduleblock_ branch from f6fef1b to 9427007 Compare February 10, 2025 17:49
Base automatically changed from 02-10-refactor_ast_estree_re-arrange_and_comment_custom_serialization_code to main February 10, 2025 17:53
@graphite-app graphite-app bot merged commit 9427007 into main Feb 10, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 02-10-fix_ast_estree_use_estree_append_to_for_tsmoduleblock_ branch February 10, 2025 17:55
This was referenced Feb 10, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST C-bug Category - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@overlookmotel