Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ast/estree): fix serializing PrivateFieldExpression #9025

Merged
merged 1 commit into from
Feb 10, 2025
Merged

fix(ast/estree): fix serializing PrivateFieldExpression #9025

merged 1 commit into from
Feb 10, 2025
+4 −3,314

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Feb 10, 2025 •
edited
Loading

Fix serializing PrivateFieldExpression.

- Positive Passed: 40622/44293 (91.71%)
+ Positive Passed: 43933/44293 (99.19%)

@github-actions github-actions bot added the A-ast Area - AST label Feb 10, 2025
@overlookmotel overlookmotel mentioned this pull request Feb 10, 2025
Merged
@github-actions github-actions bot added the C-bug Category - Bug label Feb 10, 2025
This was referenced Feb 10, 2025
Merged
Merged
Merged
Merged
@overlookmotel Graphite App
Copy link
Contributor Author

overlookmotel commented Feb 10, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review February 10, 2025 18:18
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 10, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9025 will not alter performance

Comparing 02-10-fix_ast_estree_fix_serializing_privatefieldexpression_ (e75e1d2) with main (fcb5490)

Summary

✅ 33 untouched benchmarks

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Feb 10, 2025
@overlookmotel Graphite App
Copy link
Contributor Author

overlookmotel commented Feb 10, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Feb 10, 2:31 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 10, 2:31 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 10, 2:38 PM EST: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Feb 10, 2:39 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 10, 2:40 PM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Feb 10, 7:40 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 10, 7:40 PM UTC: The merge label '0-merge' was removed. This PR will no longer be merged by the Graphite merge queue
  • Feb 10, 7:44 PM UTC: A user added this pull request to the Graphite merge queue.
  • Feb 10, 7:49 PM UTC: A user merged this pull request with the Graphite merge queue.

@overlookmotel overlookmotel changed the base branch from 02-10-fix_ast_estree_fix_serializing_importexpression_s to graphite-base/9025 February 10, 2025 19:31
@graphite-app graphite-app bot changed the base branch from graphite-base/9025 to main February 10, 2025 19:36
@graphite-app graphite-app bot added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Feb 10, 2025
@overlookmotel overlookmotel force-pushed the 02-10-fix_ast_estree_fix_serializing_privatefieldexpression_ branch from dbcedae to e4bb413 Compare February 10, 2025 19:39
@overlookmotel
fix(ast/estree): fix serializing PrivateFieldExpression (#9025)
e75e1d2 
Fix serializing `PrivateFieldExpression`.

```diff
- Positive Passed: 40622/44293 (91.71%)
+ Positive Passed: 43933/44293 (99.19%)
```
@graphite-app graphite-app bot force-pushed the 02-10-fix_ast_estree_fix_serializing_privatefieldexpression_ branch from e4bb413 to e75e1d2 Compare February 10, 2025 19:45
@graphite-app graphite-app bot merged commit e75e1d2 into main Feb 10, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 02-10-fix_ast_estree_fix_serializing_privatefieldexpression_ branch February 10, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST C-bug Category - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@overlookmotel