-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(IT Wallet): [SIW-1780] Use errors in issuance_errors_supported
when issuing credentials
#6338
chore(IT Wallet): [SIW-1780] Use errors in issuance_errors_supported
when issuing credentials
#6338
Conversation
|
issuance_errors_supported
in the issuance of credentialsissuance_errors_supported
when issuing credentials
issuance_errors_supported
when issuing credentialsissuance_errors_supported
when issuing credentials
|
4 similar comments
|
|
|
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6338 +/- ##
==========================================
- Coverage 48.42% 47.00% -1.42%
==========================================
Files 1488 1815 +327
Lines 31617 36913 +5296
Branches 7669 8780 +1111
==========================================
+ Hits 15311 17352 +2041
- Misses 16238 19504 +3266
+ Partials 68 57 -11
... and 1438 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note
Depends on pagopa/io-react-native-wallet#151
Short description
This PR adds more meaningful errors during the issuance of credentials when a credential is invalid. These errors messages are extracted from the entity configuration via a utility function exposed by
io-react-native-wallet
.List of changes proposed in this pull request
INVALID_STATUS
failure typeNOT_ENTITLED
because it can be represented withINVALID_STATUS
INVALID_STATUS
failureHow to test
Try to get a credential and use a proxy to mock the
/credential
endpoint response:{ "error": "credential_not_found" }
or another error code found in the EC'sissuance_errors_supported