Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOPID-2429] API Token Support removal #1159

Merged
merged 2 commits into from
Oct 29, 2024
Merged

[#IOPID-2429] API Token Support removal #1159

merged 2 commits into from
Oct 29, 2024

Conversation

salvatorelaiso
Copy link
Collaborator

@salvatorelaiso salvatorelaiso commented Oct 23, 2024 •
edited
Loading

List of Changes

  • Remove Support Token API.
  • Remove TokenService

Motivation and Context

The Support Token API is no longer used. As a consequence, the TokenService is not used anymore.

How Has This Been Tested?

Unit tests.

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@salvatorelaiso salvatorelaiso requested a review from a team as a code owner October 23, 2024 14:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-2429

@salvatorelaiso salvatorelaiso mentioned this pull request Oct 23, 2024
Merged
6 tasks
@salvatorelaiso salvatorelaiso marked this pull request as draft October 25, 2024 08:28
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@salvatorelaiso salvatorelaiso marked this pull request as ready for review October 25, 2024 09:02
arcogabbo
arcogabbo approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@arcogabbo arcogabbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, LGTM

@arcogabbo arcogabbo merged commit f7d83d4 into master Oct 29, 2024
7 checks passed
@arcogabbo arcogabbo deleted the IOPID-2429 branch October 29, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcogabbo arcogabbo arcogabbo approved these changes

@pagopa-github-bot pagopa-github-bot Awaiting requested review from pagopa-github-bot pagopa-github-bot is a code owner automatically assigned from pagopa/io-backend-contributors

@rodoviti rodoviti Awaiting requested review from rodoviti rodoviti is a code owner automatically assigned from pagopa/io-backend-contributors

@gquadrati gquadrati Awaiting requested review from gquadrati

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@salvatorelaiso @arcogabbo