Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towards rendering without colours #76

Merged
merged 28 commits into from
Aug 20, 2024
Merged

Towards rendering without colours #76

merged 28 commits into from
Aug 20, 2024

Conversation

yokurang
Copy link
Collaborator

@yokurang yokurang commented Aug 6, 2024

No description provided.

@yokurang yokurang requested a review from panglesd August 6, 2024 15:38
Julow

This comment was marked as resolved.

Julow

This comment was marked as resolved.

test/cram/test.t Outdated Show resolved Hide resolved
lib/HunkView.ml Outdated Show resolved Hide resolved
lib/HunkView.ml Outdated Show resolved Hide resolved
lib/HunkView.ml Outdated Show resolved Hide resolved
lib/HunkView.ml Outdated Show resolved Hide resolved
test/cram/test.t Show resolved Hide resolved
lib/HunkView.ml Outdated Show resolved Hide resolved
lib/HunkView.ml Outdated Show resolved Hide resolved
test/cram/test.t Outdated Show resolved Hide resolved
test/cram/test.t Outdated Show resolved Hide resolved
lib/HunkView.ml Outdated Show resolved Hide resolved
Copy link
Owner

@panglesd panglesd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

| TextMarkers, `Removed -> removed_marker (W.string word)
| TextMarkers, `Unchanged -> W.string word
in
Ui.hcat [ styled_word; W.string " " ]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is adding an extra space at the end of the line. However, this small bug is not introduced in this PR and should be fixed in another one.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Collaborator

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too :)

@yokurang yokurang merged commit 7309564 into main Aug 20, 2024
2 checks passed
@yokurang yokurang deleted the accessible-diff branch August 20, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants