docs(accessibility-testing): Updates content as part of content audit. #3776

edonehoo · 2023-10-11T15:12:48Z

patternfly-build · 2023-10-11T15:25:54Z

Preview: https://patternfly-org-pr-3776-site.surge.sh

jessiehuff · 2023-10-16T18:19:51Z

...ages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md

+Colors should pass the following contrast checks, to ensure that users across the vision spectrum can understand your product:
+    - Text color against background color ([Understanding WCAG 1.4.3](//www.w3.org/WAI/WCAG21/Understanding/contrast-minimum.html))
+    - Text color against link color ([Technique G183](//www.w3.org/TR/WCAG20-TECHS/G183.html))
+    - Visible boundaries of buttons and form elements against adjacent background color ([Understanding WCAG 1.4.11](//www.w3.org/WAI/WCAG21/Understanding/non-text-contrast.html))



I noticed that we removed the section on screen reader specific considerations. Do you think the information was redundant or not helpful? Perhaps we could take some of this information and put it underneath the screen reader section above to retain some of it? Curious of your thoughts on this one.

Realizing as I continued reviewing that this was added to the development section. I have mixed feelings. I remember adding it so that users understood how things differed in a screen reader for testing, but I totally get that this also affects developing. @thatblindgeye what do you think? I'm worried that being closer to the content/writing it, I might not be able to see it as objectively. 😂

Yeah that's tough because it can probably fit in either place. I feel like the content as it is probably fits closer in the development page. I guess it also depends if someone would be going through these pages in order or just what page interests them. I may have a clearer idea once I finish going through the current PRs but wondering whether linking to the development page would make sense? Sort of to convey "Also make sure you're testing stuff we mentioned on this page" or something, if that makes sense.

Yeah, that would make sense to me! I think after reviewing them a second time, I agree that that screen reader content probably makes more sense in the development section.

...ages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md

thatblindgeye

Some comments below, I still need to go through the checklist section but want to toy around with the PF checkboxes first since part of an initial comment I may have is the structure of the nested checklists.

...ages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md

thatblindgeye · 2023-10-16T20:00:10Z

...ages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md

+  - All functionality is keyboard accessible.
+  - Elements in the HTML and in the layout follow a logical order.
+  - Elements with focus are clearly visible.


This could be a great followup at some point to add illustrations (definitely out of scope here, just thinking out loud 😆 )

...ages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md

thatblindgeye · 2023-10-17T13:24:55Z

...ages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md

  - <label><input type="checkbox" /> The flow of information makes sense when navigating. Screen readers navigate the page in DOM order. If you used CSS to visually reposition elements, they might be announced in a nonsensical sequence. Instead, if you need something to appear earlier in the page, try to physically move it earlier in the DOM.</label>

-**Accessibility points** <br />
+### Accessibility points


I'm not really sure what they could be updated to, but I feel like one or both of the headings for these sections of checklists could be updated from "General criteria" and "Accessibility points". Maybe just this section, as the entire page is regarding accessibility points technically?

Also not sure whether the current/previous content here still fits or if it's either duplicate from the "general criteria" or needs a little more information. The "Links" item in the Structure section, for example, I'm not sure of the purpose there since we mention them again in the Labels section. @jessiehuff wdyt?

I agree on this! I can't immediately tell the difference between the lists, which pushes me towards a heading change or combining the two lists. But I'm not entirely sure what the common thread between the "accessibility points" section is, so I'm not sure how to go about renaming

Definitely open to different names! My original intention was that the first section was thinking about the different ways of checking things (i.e. screen reader and it's different ways of navigating and keyboard) and that essentially everything should work through each of the general a11y questions and thinking big picture (i.e. just like the questions asked in the development section - is it discoverable, able to be interacted with, and understandable). The second section was more getting into the nitty gritty of checking specific things, starting from high level like structure to more granular things like labels. So totally open to anything that communicates that better! If both of you were confused, it definitely sounds like something should be changed!

In terms of the links in both the structure and labels section, that's because when I'm testing structure, especially using the rotor menu, I check each of those major elements (headings, landmarks, links, form controls, tables) and make sure that nothing immediately looks off with the way that they're handled. That's probably not totally clear though. 🙃 I guess that's what happens when a checklist starts off as more of something for your personal use to trying to communicate it more publicly haha.

...ages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md

Co-authored-by: Eric Olkowski <[email protected]>

...ages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md

…resources/accessibility-testing.md

jessiehuff · 2023-11-22T19:28:51Z

...ages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md

-**General questions**
+  <Checkbox label={<span><b>Buttons and form controls:</b></span>} description={ <span>
+    <li> All form controls have clear and descriptive labels. </li>
+    <li> Indicate that a button has the expandable control. </li>


I think there should be some clarification on this one that this line is only applicable to expandable buttons, not all buttons.

Could be worth explicitly mentioning aria-expanded and how it should always have a boolean value if the button is intended to be expandable

andrew-ronaldson

LGTM, thanks Erin!

...ages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md

thatblindgeye · 2023-11-27T14:12:47Z

...ages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md


+    <Checkbox label={<span><b>Aria</b> provides descriptive details to screen reader users, without reiterating or overriding the text that is already there. If there is visible text then there doesn’t need to be an <span className="ws-code">aria-label</span>. </span>} description={<span>It’s important to understand that ARIA can only affect the semantics of an element; not the behavior. For example, while you can hide an element from screen readers with <span> className="ws-code">aria-hidden=”true”</span>, that does not change the focus behavior for that element.</span>} id="general-criteria-8h" />


@jessiehuff wdyt about tweaking this verbiage? Feel like we could name aria-label as a way to add a non-visual label to certain elements, and aria-labelledby to use an existing text or aria-label to label another element.

Though if this is meant to be more of a general point about aria rather than strictly labeling, maybe the verbiage about when you don't need an aria-label could be its own bullet? We do mention this in another PR as well, though: #3780 around line 39-41

Additionally, looks like the description has a typo in the description. <span> className="ws-code">aria-hidden=”true”</span> should be <span className="ws-code">aria-hidden=”true”</span>

Yeah, it was originally intended as more of a general statement of when something needs to be labeled vs. not, but admittedly I probably shouldn't have just singled out aria-label in that circumstance. (I started calling this out because I noticed that once people started trying to improve their a11y, they could at times just go crazy adding aria-labels even when there was no need for one and adding one might even make the experience worse.) Maybe we could change the aria-label in this context to a label in general and then call out your point in a bullet.

…resources/accessibility-testing.md Co-authored-by: Eric Olkowski <[email protected]>

edonehoo · 2024-01-03T16:45:33Z

@thatblindgeye @jessiehuff @andrew-ronaldson this pr is ready for another review!

...ages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md

thatblindgeye · 2024-01-04T17:00:49Z

...ages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md

+    <Checkbox label={<span><b>ARIA</b> labels provide descriptive details to screen reader users, without reiterating or overriding the text that is already there. If there is visible text then there doesn’t need to be an ARIA label. </span>} 
+    description={ <span>
+      <li> To add a non-visual label to an element you should use <span className="ws-code">aria-label</span>. Keep in mind you should not add this to an element that already has a visual label in the UI. You can also use <span className="ws-code">aria-labelledby</span> to label an element through existing text or <span className="ws-code">aria-label</span>. </li>
+      <li> <span> It’s important to understand that ARIA can only affect the semantics of an element; not the behavior. For example, while you can hide an element from screen readers with <span className="ws-code">aria-hidden=”true”</span>, that does not change the focus behavior for that element.</span></li>


Not sure if this really fits here anymore since it's more about labels than general ARIA. @jessiehuff wdyt about whether this should stay here, removed, moved to the Product Dev Guide page, or a secret 4th option that I haven't found yet?

Yeah, I see your point @thatblindgeye. Maybe it's best to just remove those subpoints? It looks like the the point about aria only affecting the semantics is already in the dev guide page, but do we have a section where we clarify the difference between aria-label and aria-labelledby? I wonder if it would make sense to remove that point here but just make sure that we have it clear in the dev docs somewhere?

@thatblindgeye @jessiehuff I can see how the aria-labelledby point may be more helpful/visible in the dev guide. I went ahead and removed the subpoints here - I can add the aria-labelledby in a separate issue (or slip it into this PR if that seems okay) - wdyt?

…resources/accessibility-testing.md Co-authored-by: Eric Olkowski <[email protected]>

thatblindgeye

We can open a followup issue to add some clarification of aria-label vs aria-lablledby if we'd like, I wouldn't hold this PR up any longer over that

patternfly#3776) * docs(accessibility-testing): Updates content as part of content audit. * Apply suggestions from code review Co-authored-by: Eric Olkowski <[email protected]> * Apply suggestions from code review * Content tweaks in progress. * Works on checkboxes. * Resolves merge conflict. * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md Co-authored-by: Eric Olkowski <[email protected]> * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md Co-authored-by: Eric Olkowski <[email protected]> * Content alterations. * Content changes from review feedback. * Updates to buttons point. * Grammar and typo updates. * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md Co-authored-by: Eric Olkowski <[email protected]> * Merging. --------- Co-authored-by: Eric Olkowski <[email protected]>

* chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * docs(extensions): Updates the extensions landing page to add reference to the component groups extension. (#3849) * (docs(extensions): Updates the extensions landing page to add reference to the component groups extension. * Update packages/documentation-site/patternfly-docs/pages/landing-pages/extensions/extensions-data.json * typo update * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * docs(accessibility-design): Adds new documentation to support content audit. (#3781) * docs(accessibility-design): Adds new documentation to support content audit. * Test page name change * Apply suggestions from code review * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-design.md * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-design.md * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-design.md * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-design.md * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-design.md * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-design.md * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-design.md * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-design.md * Remove table * Removes numbers from headings. * Makes content updates and adds images. * Updates to content describing images. * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * fix: bump puppeteer to fix core (#3860) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * Update naming for introductory pages across website sections. (#3851) * Update naming for introductory pages across website sections. * Caps change * Adjusts naming for about PatternFly page. * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * docs(accessibility-testing): Updates content as part of content audit. (#3776) * docs(accessibility-testing): Updates content as part of content audit. * Apply suggestions from code review Co-authored-by: Eric Olkowski <[email protected]> * Apply suggestions from code review * Content tweaks in progress. * Works on checkboxes. * Resolves merge conflict. * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md Co-authored-by: Eric Olkowski <[email protected]> * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md Co-authored-by: Eric Olkowski <[email protected]> * Content alterations. * Content changes from review feedback. * Updates to buttons point. * Grammar and typo updates. * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md Co-authored-by: Eric Olkowski <[email protected]> * Merging. --------- Co-authored-by: Eric Olkowski <[email protected]> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * fix: bump to latest release candidates ahead of 5.2 release (#3862) * fix: bump to latest release candidates ahead of 5.2 release * bump to latest component groups prerelease * bump react to pull in bug fix * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * updates to images to make icons black (#3856) * fix: avoid applying beta tags to nav items for next components (#3868) * fix(truncate): typos on guidelines (#3872) * docs(capitalization): Updates capitalization guidelines for better consistency and clarity. (#3855) * docs(capitalization): Updates guidance for capitalization. * Continues editing content. * Content updates progress. * Updates content and images. * Content and image updates. * Final content and image updates. * Updates recs per content team decision. * fix: add drag drop deps and remove unused code editor deps (#3866) * fix: add drag drop deps and remove unused code editor deps * bump react-docs to fix error * bump the prerelease versions * chore(Title): updated a11y docs to template (#3873) * docs(release-highlights): Adds release highlights for 5.2 release. (#3853) * docs(releases): Adds release highlights for v5.2 * docs(release-highlights): Adds release highlights for 5.2 release. * Update packages/documentation-site/patternfly-docs/content/get-started/release-highlights.md Co-authored-by: Michael Coker <[email protected]> * Adds more highlights. * Adds coming soon section. * Update packages/documentation-site/patternfly-docs/content/get-started/release-highlights.md Co-authored-by: Michael Coker <[email protected]> * Update packages/documentation-site/patternfly-docs/content/get-started/release-highlights.md Co-authored-by: Michael Coker <[email protected]> --------- Co-authored-by: Michael Coker <[email protected]> * docs(design): Adds initial information regarding Figma. (#3863) * docs(design): Adds Figma information where Sketch is currently mentioned. * Path update * Update packages/documentation-site/patternfly-docs/content/contribute/design/design.md * Path updates. * Update packages/documentation-site/patternfly-docs/content/contribute/design/design.md * Update packages/documentation-site/patternfly-docs/content/training/design.md * feat: release 5.3 (#3878) * feat: 5.3 release * update release highlights * fix: Bump topology to 5.2.1 (#3881) * fix: toplogy to 5.2.1 * add yarn.lock * update release highlights * Update broken link on develop.md * chore(deps): bump ip from 1.1.5 to 1.1.9 (#3895) Bumps [ip](https://github.com/indutny/node-ip) from 1.1.5 to 1.1.9. - [Commits](indutny/node-ip@v1.1.5...v1.1.9) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add edit modal guidance (#3836) * add edit modal guidance * edits * chore(release): Updated component groups to 5.1.0 release (#3917) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] chore(component-groups): Updated component groups to 5.1.0 release chore(component-groups): Updated component groups to 5.1.0 release * Updated version.json * feat(deps): version bump for 5.2.1 release (#3913) * feat(deps): version bump for 5.2.1 release * Update packages/documentation-framework/versions.json Co-authored-by: Evan <[email protected]> * Update packages/documentation-site/patternfly-docs/content/get-started/release-highlights.md Co-authored-by: Evan <[email protected]> * Update packages/documentation-site/patternfly-docs/content/get-started/release-highlights.md Co-authored-by: Evan <[email protected]> * Update packages/documentation-framework/versions.json * chore(deps): bump react-charts, react-docs * Update packages/documentation-site/patternfly-docs/content/get-started/release-highlights.md Co-authored-by: Erin Donehoo <[email protected]> * chore(docs): update release highlights * Update packages/documentation-framework/versions.json --------- Co-authored-by: Evan <[email protected]> Co-authored-by: Erin Donehoo <[email protected]> * chore(SkipToContent): updated a11y docs to template (#3871) * chore(SkipToContent): updated a11y docs to template * Updated test item description verbiage * feat(deps): version bump and release notes for 5.2.2 patch release (#3919) * feat(deps): version bump and release notes for 5.2.2 patch release * fix(release-highlights): correct listed table version * Update packages/documentation-site/patternfly-docs/content/get-started/release-highlights.md Co-authored-by: Erin Donehoo <[email protected]> --------- Co-authored-by: Erin Donehoo <[email protected]> * feat: add pf 6 alpha banner to home page and version switcher (#3896) * feat: add pf 6 alpha banner to home page and version switcher * update wording * feat(templates): add templates package to versions.json (#3902) * feat(templates): add templates package to versions.json for docs build * add support for template inline alert * add to patch version, update wording * update wording * bump to latest alphas * rebase from v6 branch * fix screenshot script and update screenshots * more screenshots * fix the build * update docs-framework version * address PR comments --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: patternfly-build <[email protected]> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: Margot <[email protected]> Co-authored-by: Andrew Ronaldson <[email protected]> Co-authored-by: Michael Coker <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Donald Labaj <[email protected]> Co-authored-by: Austin Sullivan <[email protected]> Co-authored-by: Evan <[email protected]> Co-authored-by: kmcfaul <[email protected]>

* chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * docs(extensions): Updates the extensions landing page to add reference to the component groups extension. (#3849) * (docs(extensions): Updates the extensions landing page to add reference to the component groups extension. * Update packages/documentation-site/patternfly-docs/pages/landing-pages/extensions/extensions-data.json * typo update * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * docs(accessibility-design): Adds new documentation to support content audit. (#3781) * docs(accessibility-design): Adds new documentation to support content audit. * Test page name change * Apply suggestions from code review * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-design.md * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-design.md * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-design.md * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-design.md * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-design.md * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-design.md * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-design.md * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-design.md * Remove table * Removes numbers from headings. * Makes content updates and adds images. * Updates to content describing images. * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * fix: bump puppeteer to fix core (#3860) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * Update naming for introductory pages across website sections. (#3851) * Update naming for introductory pages across website sections. * Caps change * Adjusts naming for about PatternFly page. * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * docs(accessibility-testing): Updates content as part of content audit. (#3776) * docs(accessibility-testing): Updates content as part of content audit. * Apply suggestions from code review Co-authored-by: Eric Olkowski <[email protected]> * Apply suggestions from code review * Content tweaks in progress. * Works on checkboxes. * Resolves merge conflict. * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md Co-authored-by: Eric Olkowski <[email protected]> * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md Co-authored-by: Eric Olkowski <[email protected]> * Content alterations. * Content changes from review feedback. * Updates to buttons point. * Grammar and typo updates. * Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md Co-authored-by: Eric Olkowski <[email protected]> * Merging. --------- Co-authored-by: Eric Olkowski <[email protected]> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * fix: bump to latest release candidates ahead of 5.2 release (#3862) * fix: bump to latest release candidates ahead of 5.2 release * bump to latest component groups prerelease * bump react to pull in bug fix * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * updates to images to make icons black (#3856) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * fix: avoid applying beta tags to nav items for next components (#3868) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * fix(truncate): typos on guidelines (#3872) * docs(capitalization): Updates capitalization guidelines for better consistency and clarity. (#3855) * docs(capitalization): Updates guidance for capitalization. * Continues editing content. * Content updates progress. * Updates content and images. * Content and image updates. * Final content and image updates. * Updates recs per content team decision. * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * fix: add drag drop deps and remove unused code editor deps (#3866) * fix: add drag drop deps and remove unused code editor deps * bump react-docs to fix error * bump the prerelease versions * chore(Title): updated a11y docs to template (#3873) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * docs(release-highlights): Adds release highlights for 5.2 release. (#3853) * docs(releases): Adds release highlights for v5.2 * docs(release-highlights): Adds release highlights for 5.2 release. * Update packages/documentation-site/patternfly-docs/content/get-started/release-highlights.md Co-authored-by: Michael Coker <[email protected]> * Adds more highlights. * Adds coming soon section. * Update packages/documentation-site/patternfly-docs/content/get-started/release-highlights.md Co-authored-by: Michael Coker <[email protected]> * Update packages/documentation-site/patternfly-docs/content/get-started/release-highlights.md Co-authored-by: Michael Coker <[email protected]> --------- Co-authored-by: Michael Coker <[email protected]> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * docs(design): Adds initial information regarding Figma. (#3863) * docs(design): Adds Figma information where Sketch is currently mentioned. * Path update * Update packages/documentation-site/patternfly-docs/content/contribute/design/design.md * Path updates. * Update packages/documentation-site/patternfly-docs/content/contribute/design/design.md * Update packages/documentation-site/patternfly-docs/content/training/design.md * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * feat: release 5.3 (#3878) * feat: 5.3 release * update release highlights * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * fix: Bump topology to 5.2.1 (#3881) * fix: toplogy to 5.2.1 * add yarn.lock * update release highlights * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * Update broken link on develop.md * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * chore(deps): bump ip from 1.1.5 to 1.1.9 (#3895) Bumps [ip](https://github.com/indutny/node-ip) from 1.1.5 to 1.1.9. - [Commits](indutny/node-ip@v1.1.5...v1.1.9) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add edit modal guidance (#3836) * add edit modal guidance * edits * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * chore(release): Updated component groups to 5.1.0 release (#3917) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] chore(component-groups): Updated component groups to 5.1.0 release chore(component-groups): Updated component groups to 5.1.0 release * Updated version.json * feat(deps): version bump for 5.2.1 release (#3913) * feat(deps): version bump for 5.2.1 release * Update packages/documentation-framework/versions.json Co-authored-by: Evan <[email protected]> * Update packages/documentation-site/patternfly-docs/content/get-started/release-highlights.md Co-authored-by: Evan <[email protected]> * Update packages/documentation-site/patternfly-docs/content/get-started/release-highlights.md Co-authored-by: Evan <[email protected]> * Update packages/documentation-framework/versions.json * chore(deps): bump react-charts, react-docs * Update packages/documentation-site/patternfly-docs/content/get-started/release-highlights.md Co-authored-by: Erin Donehoo <[email protected]> * chore(docs): update release highlights * Update packages/documentation-framework/versions.json --------- Co-authored-by: Evan <[email protected]> Co-authored-by: Erin Donehoo <[email protected]> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * chore(SkipToContent): updated a11y docs to template (#3871) * chore(SkipToContent): updated a11y docs to template * Updated test item description verbiage * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * feat(deps): version bump and release notes for 5.2.2 patch release (#3919) * feat(deps): version bump and release notes for 5.2.2 patch release * fix(release-highlights): correct listed table version * Update packages/documentation-site/patternfly-docs/content/get-started/release-highlights.md Co-authored-by: Erin Donehoo <[email protected]> --------- Co-authored-by: Erin Donehoo <[email protected]> * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * feat: add pf 6 alpha banner to home page and version switcher (#3896) * feat: add pf 6 alpha banner to home page and version switcher * update wording * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * feat(templates): add templates package to versions.json (#3902) * feat(templates): add templates package to versions.json for docs build * add support for template inline alert * add to patch version, update wording * update wording * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * chore(Page): updated a11y docs to new template (#3880) * chore(Page): updated a11y docs to new template * Removed requirement of aria-labelledby on page sections * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * chore: simplify Babel configuration (#3934) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * chore(footer): Restructure new homepage footer (#3870) * Restructure footer * Remove PageSection from footer based on conversations * Rework structure * Fix footer height issue * Update flex * Fix typo * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * feat(docs): update medium articles (#3950) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * docs(release-highlights): Creates release highlights for 5.3 release. (#3941) * docs(release-highlights): Creates release highlights for 5.3 release. * Continues working on content updates. * docs(release-highlights): Adds release highlights for 5.3 release. * Adds more context to menu toggle change. * Update packages/documentation-site/patternfly-docs/content/get-started/release-highlights.md * Update packages/documentation-site/patternfly-docs/content/get-started/release-highlights.md * Adds section for dual list selector. * Updates topology pipeline images. * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * feat(Templates): add to org site (#3947) * feat(Templates): add to org site * update versions, fix Th * hide prev version, update screenshots * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] * update documentation-framework version and git ignore * remove react-templates untill merged in react * remove 1 featured post --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: patternfly-build <[email protected]> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Nicole Thoen <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: Margot <[email protected]> Co-authored-by: Andrew Ronaldson <[email protected]> Co-authored-by: Michael Coker <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Donald Labaj <[email protected]> Co-authored-by: Austin Sullivan <[email protected]> Co-authored-by: Evan <[email protected]> Co-authored-by: kmcfaul <[email protected]> Co-authored-by: Jon Koops <[email protected]> Co-authored-by: Jessie <[email protected]> Co-authored-by: Titani <[email protected]>

docs(accessibility-testing): Updates content as part of content audit.

ea7b05e

edonehoo self-assigned this Oct 11, 2023

jessiehuff reviewed Oct 16, 2023

View reviewed changes

thatblindgeye reviewed Oct 16, 2023

View reviewed changes

thatblindgeye reviewed Oct 17, 2023

View reviewed changes

edonehoo commented Oct 20, 2023

View reviewed changes

...ages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md Outdated Show resolved Hide resolved

edonehoo commented Oct 20, 2023

View reviewed changes

...ages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md Outdated Show resolved Hide resolved

edonehoo commented Oct 20, 2023

View reviewed changes

...ages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md Outdated Show resolved Hide resolved

edonehoo commented Oct 20, 2023

View reviewed changes

...ages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md Outdated Show resolved Hide resolved

edonehoo commented Oct 20, 2023

View reviewed changes

...ages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md Outdated Show resolved Hide resolved

edonehoo commented Oct 20, 2023

View reviewed changes

...ages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md Outdated Show resolved Hide resolved

edonehoo commented Oct 20, 2023

View reviewed changes

...ages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md Outdated Show resolved Hide resolved

edonehoo commented Oct 20, 2023

View reviewed changes

...ages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md Outdated Show resolved Hide resolved

edonehoo and others added 2 commits October 20, 2023 15:28

Apply suggestions from code review

a843b8a

Co-authored-by: Eric Olkowski <[email protected]>

Merge branch 'main' into iss3695

685182d

edonehoo commented Oct 24, 2023

View reviewed changes

edonehoo and others added 5 commits October 24, 2023 17:59

Apply suggestions from code review

f116521

Content tweaks in progress.

3c10385

Works on checkboxes.

51d3a16

Resolves merge conflict.

2003d3e

Merge branch 'main' into iss3695

cd89723

edonehoo commented Oct 31, 2023

View reviewed changes

...ages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md Outdated Show resolved Hide resolved

edonehoo added 2 commits October 31, 2023 10:55

Update packages/documentation-site/patternfly-docs/content/developer-…

29d4753

…resources/accessibility-testing.md

Merge branch 'main' into iss3695

a144112

edonehoo requested review from jessiehuff, thatblindgeye and andrew-ronaldson November 7, 2023 15:25

jessiehuff reviewed Nov 22, 2023

View reviewed changes

andrew-ronaldson previously approved these changes Nov 23, 2023

View reviewed changes

thatblindgeye requested changes Nov 27, 2023

View reviewed changes

edonehoo dismissed andrew-ronaldson’s stale review via c212ec5 December 4, 2023 20:46

edonehoo and others added 7 commits December 4, 2023 15:46

Update packages/documentation-site/patternfly-docs/content/developer-…

c212ec5

…resources/accessibility-testing.md Co-authored-by: Eric Olkowski <[email protected]>

Update packages/documentation-site/patternfly-docs/content/developer-…

643b38b

…resources/accessibility-testing.md Co-authored-by: Eric Olkowski <[email protected]>

Content alterations.

fcc4cff

Content changes from review feedback.

bcd2f3e

Updates to buttons point.

8e4edbf

Grammar and typo updates.

3f86f36

Merge branch 'main' into iss3695

06e99f0

thatblindgeye reviewed Jan 4, 2024

View reviewed changes

edonehoo and others added 2 commits January 5, 2024 10:21

Update packages/documentation-site/patternfly-docs/content/developer-…

83b658a

…resources/accessibility-testing.md Co-authored-by: Eric Olkowski <[email protected]>

Merging.

16d508d

thatblindgeye approved these changes Jan 15, 2024

View reviewed changes

jessiehuff approved these changes Jan 15, 2024

View reviewed changes

jessiehuff merged commit c35ccf7 into patternfly:main Jan 15, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs(accessibility-testing): Updates content as part of content audit. #3776

docs(accessibility-testing): Updates content as part of content audit. #3776

edonehoo commented Oct 11, 2023

patternfly-build commented Oct 11, 2023 •

edited

Loading

jessiehuff Oct 16, 2023

jessiehuff Oct 16, 2023

thatblindgeye Oct 16, 2023

jessiehuff Nov 22, 2023

thatblindgeye left a comment

thatblindgeye Oct 16, 2023

thatblindgeye Oct 17, 2023

edonehoo Oct 27, 2023

jessiehuff Nov 22, 2023 •

edited

Loading

jessiehuff Nov 22, 2023

thatblindgeye Nov 27, 2023

andrew-ronaldson left a comment

thatblindgeye Nov 27, 2023 •

edited

Loading

jessiehuff Nov 28, 2023

edonehoo commented Jan 3, 2024

thatblindgeye Jan 4, 2024

jessiehuff Jan 5, 2024

edonehoo Jan 8, 2024

thatblindgeye left a comment


		<Checkbox label={<span><b>Aria</b> provides descriptive details to screen reader users, without reiterating or overriding the text that is already there. If there is visible text then there doesn’t need to be an <span className="ws-code">aria-label</span>. </span>} description={<span>It’s important to understand that ARIA can only affect the semantics of an element; not the behavior. For example, while you can hide an element from screen readers with <span> className="ws-code">aria-hidden=”true”</span>, that does not change the focus behavior for that element.</span>} id="general-criteria-8h" />

docs(accessibility-testing): Updates content as part of content audit. #3776

docs(accessibility-testing): Updates content as part of content audit. #3776

Conversation

edonehoo commented Oct 11, 2023

patternfly-build commented Oct 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thatblindgeye left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jessiehuff Nov 22, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrew-ronaldson left a comment

Choose a reason for hiding this comment

thatblindgeye Nov 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

edonehoo commented Jan 3, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thatblindgeye left a comment

Choose a reason for hiding this comment

patternfly-build commented Oct 11, 2023 •

edited

Loading

jessiehuff Nov 22, 2023 •

edited

Loading

thatblindgeye Nov 27, 2023 •

edited

Loading