Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TcBSD PLC Swap / Minor grating pitch tune #109

Merged
merged 6 commits into from
Jan 5, 2024

Conversation

nrwslac
Copy link
Contributor

@nrwslac nrwslac commented Nov 9, 2023

Description

  • Set Grating deadband wider 20 nrad instead of 10.
  • Rebuild with TwinCAT/BSD plc-rixs-optics
  • 4 Cores allocated
  • 3 dedicated Cores, one allocated to NC, PlcTask, and PlcDaq
  • Needed to manually install TF6310-TCP-IP: 2.0.14.0_26 for daq UDP interface to work.
  • Add sync groups for SL1K2 and SP1K1.

Motivation and Context

  • PLC CPU overloaded
  • SP1K1 Grating Pitch Unstable

How Has This Been Tested?

  • RIX Optics all appear back online via the Lucid and PyDm screens.

Where Has This Been Documented?

https://jira.slac.stanford.edu/browse/ECS-4002

Screenshots (if appropriate):

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to fixed versions and not Always Newest
  • Code committed with pre-commit (alternatively pre-commit run --all-files)

@nrwslac nrwslac marked this pull request as ready for review December 7, 2023 00:07
@nrwslac nrwslac changed the title ENH: update control loop params for gpi TcBSD PLC Swap / Minor grating pitch tune Dec 7, 2023
@nrwslac nrwslac requested a review from jyotiphy December 7, 2023 22:15
@nrwslac nrwslac requested a review from ghalym December 12, 2023 19:24
Copy link
Collaborator

@ghalym ghalym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so we can move forward with Exit slits work.

@ghalym ghalym merged commit 87051f9 into pcdshub:master Jan 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants