change gz check to check suffix of path #98
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just had this fail because I put a
.fna
file in a tempdir. Callingmktemp
rolled me a path withgz
right in the middle (/foo/xxgzxx/myfile.fna
).I'm wondering if we can make this more strict. I can't think of a good case where a gz would have gz not as it's suffix. Maybe some folks use
.gzip
but I can't recall seeing that.Thanks!