Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change gz check to check suffix of path #98

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

jchorl
Copy link

@jchorl jchorl commented Jan 21, 2025

I just had this fail because I put a .fna file in a tempdir. Calling mktemp rolled me a path with gz right in the middle (/foo/xxgzxx/myfile.fna).

I'm wondering if we can make this more strict. I can't think of a good case where a gz would have gz not as it's suffix. Maybe some folks use .gzip but I can't recall seeing that.

Thanks!

@kbessonov1984
Copy link
Collaborator

Sure, I did not realize that case scenario where gz could indeed be present in the path. I like your modification and will merge it after the CI unit tests

@kbessonov1984 kbessonov1984 merged commit 6069135 into phac-nml:master Jan 22, 2025
1 check passed
@kbessonov1984
Copy link
Collaborator

This PR will also be incorporated in the build #2 in conda with the same release version 2.0.0. Many thanks

@jchorl
Copy link
Author

jchorl commented Jan 22, 2025

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants