-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Report Preview
into Build Report
tab
#512
Conversation
… comments, encouraging long form reporting by users. did not add it to formal report yet. I also want to reformat the download configs and share them with the download handlers.
Codecov Report
@@ Coverage Diff @@
## dev #512 +/- ##
==========================================
+ Coverage 82.51% 83.68% +1.16%
==========================================
Files 25 25
Lines 2826 2776 -50
==========================================
- Hits 2332 2323 -9
+ Misses 494 453 -41
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
FYI - I wanted to implement a markdown editor instead of a boring |
@ScottSchumacker & @Robert-Krajcik, I fixed my merge conflicts w/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good to Me, @AARON-CLARK
Closes #348.
The thinking here is the report preview tab is not just for visualizing the report, but it's also for configuring and capturing other important information that orgs may want to keep track of (in one place - the app). This solution offers a long form "summary" section where users can fill it up with whatever content they want. Not just content about
riskmetric
metrics. "Overall Comment" is still nice to have, but it is intended to be short hand.Currently, this PR is a work-in-progress but includes a fully functional "module" to allowing the creation of "pkg_summary" comments in the db (abbreviation = "s"). If you test, you will see that "Submit" and "edit" buttons appear and disappear as needed. Also, once submitted, the text box is disabled until "Edit" is clicked. Below, you can see that I made the Report contain headers just like the HTML report, and put a shaded box and border around the div so that it really pops and looks like a page.
TODO:
Introduce markdown editor intothis is on holdBuild Report
tabWould love to think of a way to create a reporting template that others can use