Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix delete package bug #782

Merged
merged 6 commits into from
May 31, 2024
Merged

Fix delete package bug #782

merged 6 commits into from
May 31, 2024

Conversation

jthompson-arcus
Copy link
Collaborator

Closes #718

@jthompson-arcus jthompson-arcus marked this pull request as ready for review May 31, 2024 14:26
aclark02-arcus
aclark02-arcus requested changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@aclark02-arcus aclark02-arcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm! However, I don't think you added a bullet point to the news file for your last PR (incorporating decisions in the CSV upload file). Do you kind adding a line to this PR? Thanks!

aclark02-arcus
aclark02-arcus approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@aclark02-arcus aclark02-arcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aclark02-arcus aclark02-arcus merged commit 13ca74e into dev May 31, 2024
1 check passed
@jthompson-arcus jthompson-arcus deleted the jt-781-fix_delete_pkg_bug branch June 12, 2024 12:49
@aclark02-arcus aclark02-arcus mentioned this pull request Jun 12, 2024
Closed
@aclark02-arcus aclark02-arcus mentioned this pull request Jun 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclark02-arcus aclark02-arcus aclark02-arcus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jthompson-arcus @aclark02-arcus @actions-user