Refactor pipelines to get R version only once for downstream workflows #2199
Conversation
|
.github/workflows/common.yml
Outdated
| style: | ||
| name: Code Style | ||
| uses: pharmaverse/admiralci/.github/workflows/style.yml@main | ||
| uses: pharmaverse/admiralci/.github/workflows/style.yml@no-get-r-version-job |
There was a problem hiding this comment.
Change these back to main when pharmaverse/admiralci#160 is merged
| get_r_version: | ||
| name: Get R version | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| r-version: ${{ steps.get_r_version.outputs.R_VERSION }} | ||
| steps: | ||
| - name: Get R Version for Downstream Container Jobs | ||
| id: get_r_version | ||
| run: echo "R_VERSION=$R_VERSION" >> $GITHUB_OUTPUT | ||
| shell: bash |
There was a problem hiding this comment.
We also need to make similar changes in other repositories (ophtha etc)
cicdguy
changed the title
|
is this still doable @cicdguy or getting tricky? |
|
The PR for the core workflow update needs to be merged and the change set from this PR needs to be propagated to other PRs |
This is done! Can we get this merged in!?! I'm excited to clean up our workflows!! Thanks again to you and @dgrassellyb for doing this!!! |
Just needed to fix some conflicts, all checks passed so I just merged it ! |
Tests getting R version at the consumer level instead of getting it from the core pipeline from
admiralci