Refactor pipelines to get R version only once for downstream workflows #2199
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,43 +33,61 @@ concurrency: | |
| group: admiral-${{ github.event.pull_request.number || github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| env: | ||
| R_VERSION: "4.1" | ||
|
|
||
| jobs: | ||
| get_r_version: | ||
| name: Get R version | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| r-version: ${{ steps.get_r_version.outputs.R_VERSION }} | ||
| steps: | ||
| - name: Get R Version for Downstream Container Jobs | ||
| id: get_r_version | ||
| run: echo "R_VERSION=$R_VERSION" >> $GITHUB_OUTPUT | ||
| shell: bash | ||
| style: | ||
| name: Code Style | ||
| uses: pharmaverse/admiralci/.github/workflows/style.yml@no-get-r-version-job | ||
|
There was a problem hiding this comment. Change these back to |
||
| if: github.event_name == 'pull_request' | ||
| needs: get_r_version | ||
| with: | ||
| r-version: "${{ needs.get_r_version.outputs.r-version }}" | ||
| spellcheck: | ||
| name: Spelling | ||
| uses: pharmaverse/admiralci/.github/workflows/spellcheck.yml@no-get-r-version-job | ||
| if: github.event_name == 'pull_request' | ||
| needs: get_r_version | ||
| with: | ||
| r-version: "${{ needs.get_r_version.outputs.r-version }}" | ||
| readme: | ||
| name: Render README | ||
| uses: pharmaverse/admiralci/.github/workflows/readme-render.yml@no-get-r-version-job | ||
| if: github.event_name == 'push' | ||
| needs: get_r_version | ||
| with: | ||
| r-version: "${{ needs.get_r_version.outputs.r-version }}" | ||
| validation: | ||
| name: Validation | ||
| uses: pharmaverse/admiralci/.github/workflows/r-pkg-validation.yml@no-get-r-version-job | ||
| if: github.event_name == 'release' | ||
| needs: get_r_version | ||
| with: | ||
| r-version: "${{ needs.get_r_version.outputs.r-version }}" | ||
| check: | ||
| name: Check | ||
| uses: pharmaverse/admiralci/.github/workflows/r-cmd-check.yml@no-get-r-version-job | ||
| with: | ||
| error-on: warning # TODO: find a way to ignore specific notes | ||
| if: github.event_name == 'pull_request' | ||
| docs: | ||
| name: Documentation | ||
| uses: pharmaverse/admiralci/.github/workflows/pkgdown.yml@no-get-r-version-job | ||
| if: github.event_name == 'push' || startsWith(github.ref, 'refs/tags/v') | ||
| needs: get_r_version | ||
| with: | ||
| r-version: "${{ needs.get_r_version.outputs.r-version }}" | ||
| # Whether to skip multiversion docs | ||
| # Note that if you have multiple versions of docs, | ||
| # your URL links are likely to break due to path changes | ||
|
|
@@ -80,28 +98,40 @@ jobs: | |
| ^cran-release$|^v([0-9]+\\.)?([0-9]+\\.)?([0-9]+)$ | ||
| linter: | ||
| name: Lint | ||
| uses: pharmaverse/admiralci/.github/workflows/lintr.yml@no-get-r-version-job | ||
| needs: get_r_version | ||
| if: github.event_name == 'pull_request' | ||
| with: | ||
| r-version: "${{ needs.get_r_version.outputs.r-version }}" | ||
| links: | ||
| name: Links | ||
| uses: pharmaverse/admiralci/.github/workflows/links.yml@no-get-r-version-job | ||
| if: github.event_name == 'pull_request' | ||
| coverage: | ||
| name: Code Coverage | ||
| uses: pharmaverse/admiralci/.github/workflows/code-coverage.yml@no-get-r-version-job | ||
| if: > | ||
| github.event_name != 'release' | ||
| needs: get_r_version | ||
| with: | ||
| r-version: "${{ needs.get_r_version.outputs.r-version }}" | ||
| # Whether to skip code coverage badge creation | ||
| # Setting to 'false' will require you to create | ||
| # an orphan branch called 'badges' in your repository | ||
| skip-coverage-badges: false | ||
| man-pages: | ||
| name: Man Pages | ||
| uses: pharmaverse/admiralci/.github/workflows/man-pages.yml@no-get-r-version-job | ||
| if: github.event_name == 'pull_request' | ||
| needs: get_r_version | ||
| with: | ||
| r-version: "${{ needs.get_r_version.outputs.r-version }}" | ||
| templates: | ||
| name: Check Templates | ||
| uses: pharmaverse/admiralci/.github/workflows/check-templates.yml@no-get-r-version-job | ||
| secrets: inherit | ||
| if: github.event_name == 'pull_request' || github.event_name == 'workflow_dispatch' | ||
| needs: get_r_version | ||
| with: | ||
| r-version: "${{ needs.get_r_version.outputs.r-version }}" | ||
| push-templates-data: true | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to make similar changes in other repositories (ophtha etc)