MASTER :: NOTICKET :: Updated phpredis version to latest 5.3.1 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good |
bioshazard
approved these changes
Aug 28, 2020
tekante
reviewed
Aug 28, 2020
| @@ -31,7 +31,7 @@ RUN ln -sfv ${PHP_HOME}/root/usr/bin/* /usr/bin/ && \ | |||
| ln -sfv /dev/stderr /var${PHP_HOME}/log/php-fpm/error.log | |||
|
|
|||
| # Install phpredis | |||
| ENV PHPREDIS_VERSION 3.1.2 | |||
| ENV PHPREDIS_VERSION 5.3.1 | |||
There was a problem hiding this comment.
Are comfortable with compatibility with this level of jump? For the php 7.4 branch I had to move it to 3.1.5 but I only picked that as a "closest to the one that we have that works" type approach. If various testing has shown that this jump appears safe I have no problem merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.