Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MASTER :: NOTICKET :: Updated phpredis version to latest 5.3.1 #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MASTER :: NOTICKET :: Updated phpredis version to latest 5.3.1 #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion php73/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ RUN ln -sfv ${PHP_HOME}/root/usr/bin/* /usr/bin/ && \
ln -sfv /dev/stderr /var${PHP_HOME}/log/php-fpm/error.log

# Install phpredis
ENV PHPREDIS_VERSION 3.1.2
ENV PHPREDIS_VERSION 5.3.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are comfortable with compatibility with this level of jump? For the php 7.4 branch I had to move it to 3.1.5 but I only picked that as a "closest to the one that we have that works" type approach. If various testing has shown that this jump appears safe I have no problem merging.

RUN curl -L -o /tmp/phpredis.tar.gz "https://github.com/phpredis/phpredis/archive/$PHPREDIS_VERSION.tar.gz" && \
tar -xzf /tmp/phpredis.tar.gz -C /tmp && \
rm /tmp/phpredis.tar.gz && \
Expand Down