-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review string reachability and tandems in phet-io #145
Comments
@jonathanolson I reviewed Density on master, with a focus on dynamic layout and string discoverability in the Studio tree. Generally, I expect to see strings related to UI components like sliders and radio buttons linked in the tree, which I see already in Density. I would also expect to see things like panel/AccordionBox titles instrumented/linked too (which I don't). I would not, however, expect to see all of the strings related to the Density Table exposed in the Studio Tree. Overall, I think Density is looking good. There are a few places where string discoverability could be better.
|
Tagging for #150 |
@samreid this also looks like an issue you can handle (if time allows). I reviewed dynamic strings/layout in Density, and it generally all looked good. I found a few places where it would be nice to link the strings to the view. See #145 (comment) for the checklist. |
This issue was still assigned to me from the prior iteration, and I considered unassigning it until a density-focused iteration. But I checked and it seemed straightforward to instrument the Text instances with those strings, so I decided to go for it. @arouinfar or @jonathanolson do not feel obligated to spend time on this if it is not in line with your current priorities. |
The API file is very stale. I'll regenerate it before starting. |
I instrumented the |
Thanks @samreid!
Looks good for Compare, but was missed on Mystery. @jonathanolson on the Mystery screen, can you add |
Implemented above, can you verify? |
Looks good, thanks @jonathanolson! |
I'm curious if I should be adding tandems to currently un-tandem'ed string "derived" Properties
The text was updated successfully, but these errors were encountered: