Fixed Improper Method Call: Replaced NotImplementedError

[fazledyn-or]

Details

While triaging your project, our bug fixing tool generated the following message(s)-

In file: parameters.py, class: ParameterSet, there is a special method __gt__ that raises a NotImplementedError. If a special method supporting a binary operation is not implemented it should return NotImplemented. On the other hand, NotImplementedError should be raised from abstract methods inside user defined base classes to indicate that derived classes should override those methods. iCR suggested that the special method __gt__ should return NotImplemented instead of raising an exception. An example of how NotImplemented helps the interpreter support a binary operation is here.

Related Documentation

• docs.python.org - NotImplemented
• docs.python.org - NotImplementedError

Changes

• Replaced NotImplementedError with NotImplemented

Previously Found & Fixed

• https://www.github.com/SciTools/iris/pull/5544
• https://www.github.com/cupy/cupy/pull/7900
• https://www.github.com/ethereum/web3.py/pull/3080

CLA Requirements

This section is only relevant if your project requires contributors to sign a Contributor License Agreement (CLA) for external contributions.

All contributed commits are already automatically signed off.

The meaning of a signoff depends on the project, but it typically certifies that committer has the rights to submit this work under the same license and agrees to a Developer Certificate of Origin (see https://developercertificate.org/ for more information).
- Git Commit SignOff documentation

Sponsorship and Support

This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF): Project Alpha-Omega. Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed – to improve global software supply chain security.

The bug is found by running the Intelligent Code Repair (iCR) tool by OpenRefactory and then manually triaging the results.

[kecnry]

Thanks for this update! I'll merge once tests pass and this will make its way to main and other dev branches on the next bugfix release.