Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Improper Method Call: Replaced NotImplementedError #795

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Fixed Improper Method Call: Replaced NotImplementedError #795

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions phoebe/parameters/parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,22 +673,22 @@ def __str__(self):
return "ParameterSet: {} parameters\n".format(len(self._params))+param_info

def __lt__(self, other):
raise NotImplementedError("comparison operators with ParameterSets are not supported")
return NotImplemented

def __le__(self, other):
raise NotImplementedError("comparison operators with ParameterSets are not supported")
return NotImplemented

def __gt__(self, other):
raise NotImplementedError("comparison operators with ParameterSets are not supported")
return NotImplemented

def __ge__(self, other):
raise NotImplementedError("comparison operators with ParameterSets are not supported")
return NotImplemented

def __eq__(self, other):
raise NotImplementedError("comparison operators with ParameterSets are not supported")
return NotImplemented

def __ne__(self, other):
raise NotImplementedError("comparison operators with ParameterSets are not supported")
return NotImplemented

def copy(self):
"""
Expand Down Expand Up @@ -1746,7 +1746,7 @@ def __add__(self, other):
ps._bundle = self._bundle
return ps
else:
raise NotImplementedError
return NotImplemented

def __sub__(self, other):
"""Subtracting 2 PSs returns a new PS with items in the first but not second."""
Expand All @@ -1761,7 +1761,7 @@ def __sub__(self, other):
ps._bundle = self._bundle
return ps
else:
raise NotImplementedError
return NotImplemented

def __mul__(self, other):
"""
Expand All @@ -1777,7 +1777,7 @@ def __mul__(self, other):
ps._bundle = self._bundle
return ps
else:
raise NotImplementedError
return NotImplemented

@classmethod
def open(cls, filename):
Expand Down