Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log to stderr by default, not stdout #80

Merged
merged 1 commit into from
Mar 28, 2024

Commits on Mar 28, 2024

  1. Log to stderr by default, not stdout

    Go's log package writes to stderr by default (like all/most loggers).
    However pion's logger by default writes to stdout by default, even
    though pion's packages that use the logger override this to stderr.
    So projects using both will end up with a mix of log messages to stdout
    and stderr, which isn't desirable when trying to separate out the
    log output. The unit test for the pion logger also writes to stdout,
    which is inconsistent with pion's actual usage whereby the default
    output is overridden with stderr. This PR changes the default
    logging fd to stderr, and also changes the logger test to be
    consistent with pion's usage in writing to stderr.
    adriancable authored and Sean-Der committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    3575446 View commit details
    Browse the repository at this point in the history