Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log to stderr by default, not stdout #80

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Log to stderr by default, not stdout #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions logger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@
// NewDefaultLeveledLoggerForScope returns a configured LeveledLogger
func NewDefaultLeveledLoggerForScope(scope string, level LogLevel, writer io.Writer) *DefaultLeveledLogger {
if writer == nil {
writer = os.Stdout
writer = os.Stderr

Check warning on line 159 in logger.go

View check run for this annotation

Codecov / codecov/patch

logger.go#L159 

Added line #L159 was not covered by tests
}
logger := &DefaultLeveledLogger{
writer: &loggerWriter{output: writer},
Expand All @@ -182,7 +182,7 @@
factory := DefaultLoggerFactory{}
factory.DefaultLogLevel = LogLevelError
factory.ScopeLevels = make(map[string]LogLevel)
factory.Writer = os.Stdout
factory.Writer = os.Stderr

Check warning on line 185 in logger.go

View check run for this annotation

Codecov / codecov/patch

logger.go#L185 

Added line #L185 was not covered by tests

logLevels := map[string]LogLevel{
"DISABLE": LogLevelDisabled,
Expand Down
6 changes: 3 additions & 3 deletions logging_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ func testErrorLevel(t *testing.T, logger *logging.DefaultLeveledLogger) {

func TestDefaultLoggerFactory(t *testing.T) {
f := logging.DefaultLoggerFactory{
Writer: os.Stdout,
Writer: os.Stderr,
DefaultLogLevel: logging.LogLevelWarn,
ScopeLevels: map[string]logging.LogLevel{
"foo": logging.LogLevelDebug,
Expand All @@ -100,7 +100,7 @@ func TestDefaultLoggerFactory(t *testing.T) {

func TestDefaultLogger(t *testing.T) {
logger := logging.
NewDefaultLeveledLoggerForScope("test1", logging.LogLevelWarn, os.Stdout)
NewDefaultLeveledLoggerForScope("test1", logging.LogLevelWarn, os.Stderr)

testNoDebugLevel(t, logger)
testWarnLevel(t, logger)
Expand All @@ -109,7 +109,7 @@ func TestDefaultLogger(t *testing.T) {

func TestSetLevel(t *testing.T) {
logger := logging.
NewDefaultLeveledLoggerForScope("testSetLevel", logging.LogLevelWarn, os.Stdout)
NewDefaultLeveledLoggerForScope("testSetLevel", logging.LogLevelWarn, os.Stderr)

testNoDebugLevel(t, logger)
logger.SetLevel(logging.LogLevelDebug)
Expand Down
Loading