Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardening suggestions for codemodder-java / ISS-2215/convert-remediators #461

Merged

Conversation

pixeebot[bot]
Copy link
Contributor

@pixeebot pixeebot bot commented Oct 21, 2024

I've reviewed the recently opened PR (460 - Converted some remediators to new API) and have identified some area(s) that could benefit from additional hardening measures.

These changes should help prevent potential security vulnerabilities and improve overall code quality.

Thank you for your consideration!
🧚🤖 Powered by Pixeebot

Feedback | Community | Docs

@pixeebot pixeebot bot requested a review from andrecsilva October 21, 2024 11:59
/**
* Build a {@link io.codemodder.CodemodChange} for this code change that fixes the given issues.
*/
private static <T> @NotNull CodemodChange buildFixChange(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed unused private method.

/**
* Build a {@link io.codemodder.CodemodChange} for this code change that fixes the given issues.
*/
private static <T> @NotNull CodemodChange buildFixChange(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed unused private method.

Copy link

sonarcloud bot commented Oct 21, 2024

@andrecsilva andrecsilva merged commit fbe740b into ISS-2215/convert-remediators Oct 21, 2024
2 checks passed
@andrecsilva andrecsilva deleted the pixeebot/ISS-2215/convert-remediators branch October 21, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant