Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardening suggestions for codemodder-java / ISS-2215/convert-remediators #461

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Hardening suggestions for codemodder-java / ISS-2215/convert-remediators #461

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14f4ee2
(Sonar) Fixed finding: "Unused private methods should be removed"
pixeebot[bot] Oct 21, 2024
bc7c92f
:art: Apply formatting
pixeebot[bot] Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions ...in/java/io/codemodder/remediation/javadeserialization/JavaDeserializationFixStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,19 +98,6 @@ public SuccessOrReason fix(final CompilationUnit cu, final Node node) {
return SuccessOrReason.success(List.of(DependencyGAV.JAVA_SECURITY_TOOLKIT));
}

/**
* Build a {@link io.codemodder.CodemodChange} for this code change that fixes the given issues.
*/
private static <T> @NotNull CodemodChange buildFixChange(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed unused private method.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed unused private method.

final DetectorRule detectorRule,
final Function<T, String> getKey,
final Function<T, Integer> getLine,
final List<T> issues) {
return CodemodChange.from(
getLine.apply(issues.get(0)),
List.of(DependencyGAV.JAVA_SECURITY_TOOLKIT),
issues.stream().map(i -> new FixedFinding(getKey.apply(i), detectorRule)).toList());
}

private void fixObjectInputStreamCreation(final ObjectCreationExpr objCreation) {
replace(objCreation)
Expand Down
Loading