Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip k8s resources that have an empty name during resource deletion #2032

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

ddelnano
Copy link
Member

Summary: Skip k8s resources that have an empty name during resource deletion

Newer versions of k8s break our px delete cli logic (see details on #2029). I tracked this down to the the condition function in our ObjectDeleter. I believe the newer versions of k8s added resources that match our visitor, but don't have a resource name. From my testing, it seemed related to the ValidatingAdmissionPolicies or ValidatingAdmissionPolicyBindings resources.

Relevant Issues: Closes #2029

Type of change: /kind bugfix

Test Plan: Deployed a vizier and verified that a subsequent px delete deleted the following

  • pl namespace
  • px-operator namespace
  • Cluster scoped resources: pl-cloud-connector-role, pl-vizier-metadata and pl-node-view cluster roles

Changelog Message: Fixed an issue that caused px delete to fail on newer k8s clusters (1.30 and later)

@ddelnano ddelnano requested a review from a team as a code owner September 24, 2024 17:20
@aimichelle aimichelle merged commit 7a468a4 into pixie-io:main Sep 24, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

px delete fails on recent K8s versions (1.30)
2 participants