Skip k8s resources that have an empty name during resource deletion #2032
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Skip k8s resources that have an empty name during resource deletion
Newer versions of k8s break our
px delete
cli logic (see details on #2029). I tracked this down to the the condition function in our ObjectDeleter. I believe the newer versions of k8s added resources that match our visitor, but don't have a resource name. From my testing, it seemed related to theValidatingAdmissionPolicies
orValidatingAdmissionPolicyBindings
resources.Relevant Issues: Closes #2029
Type of change: /kind bugfix
Test Plan: Deployed a vizier and verified that a subsequent
px delete
deleted the followingpl
namespacepx-operator
namespacepl-cloud-connector-role
,pl-vizier-metadata
andpl-node-view
cluster rolesChangelog Message: Fixed an issue that caused
px delete
to fail on newer k8s clusters (1.30 and later)