fix HPA api version #117
Merged
fix HPA api version #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Noamshmueli To keep this chart compatible with older k8s version, I suggest it detect kubernetes version and use the right apiVersion. #16 pointed out that we can use |
|
@pmint93 I got you and look into it but seems like |
Noamshmueli
force-pushed
the
bugfix/hpa-version
branch
from
022928d
to
6f81195
Compare
Noamshmueli
force-pushed
the
bugfix/hpa-version
branch
2 times, most recently
from
003a190
to
31091bd
Compare
of course it is stable version, but what I mean is: |
|
Done @pmint93 |
pmint93
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix HPA api version to
autoscaling/v2