Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(secret): support env from secret #73

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Conversation

oziey88
Copy link
Contributor

@oziey88 oziey88 commented Aug 11, 2023

getting an env from secret is useful when we want to add another ENV without adding additional ENV on the deployment manifest. yet we can also use externalsecret to generate the secret from another secret provider

@pmint93
Copy link
Owner

pmint93 commented Aug 14, 2023

@oziey88 I have wanted to move all environment variables to secret (or configmap) but don't have the chance to do it yet. It would be amazing if you (or anyone) can make me a favor by doing that.

In case you just want to focus on this PR only, I suggest you use the field named envFrom: [] instead of secret: {} to prevent confusing

Last but not least, don't forget to bump the chart version in Chart.yaml

@oziey88
Copy link
Contributor Author

oziey88 commented Aug 14, 2023

Hi @pmint93
Thank you for the feedback. will update the variable key and chart version.

IMHO,
not all environment variables are necessarily moved to secret, what we already have in this chart is good enough.
like SSL and database, it's easy to understand when we have a dedicated section for it on the values.yaml.

my PR is meant to cover the credentials, hence we are not putting it on values.yaml

@pmint93 pmint93 merged commit 0d86224 into pmint93:master Aug 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants