Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(secret): support env from secret #73

Merged
merged 3 commits into from
Aug 15, 2023
Merged

feat(secret): support env from secret #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fdcd297
feat(env): support env from secret and configMap
oziey88 Aug 11, 2023
1769beb
chore(Doc): add envFrom
oziey88 Aug 14, 2023
b4cc060
chore(chart): bump Chart version
oziey88 Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/metabase/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description:
The easy, open source way for everyone in your company to ask questions
and learn from data.
name: metabase
version: 2.7.6
version: 2.7.7
appVersion: v0.46.6.4
maintainers:
- name: pmint93
Expand Down
1 change: 1 addition & 0 deletions charts/metabase/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,5 +146,6 @@ The following table lists the configurable parameters of the Metabase chart and
| session.maxSessionAge | Session expiration defined in minutes | 20160 |
| session.sessionCookies | When browser is closed, user login session will expire | null |
| extraEnv | Mapping of extra environment variables | {} |
| envFrom | Mapping of extra environment variables from secret and/or configMap | [] |

The above parameters map to the env variables defined in [metabase](http://github.com/metabase/metabase). For more information please refer to the [metabase documentations](https://www.metabase.com/docs/v0.41/operations-guide/environment-variables.html).
7 changes: 7 additions & 0 deletions charts/metabase/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,13 @@ spec:
{{- if gt (len .Values.extraEnv) 0 }}
{{- .Values.extraEnv | toYaml | nindent 10 }}
{{- end }}
{{- if gt (len .Values.envFrom) 0 }}
envFrom:
{{- range .Values.envFrom }}
- {{ .type }}Ref:
name: {{ .name }}
{{- end }}
{{- end }}
ports:
- containerPort: {{ .Values.service.internalPort }}
{{- if .Values.monitoring.enabled }}
Expand Down
6 changes: 6 additions & 0 deletions charts/metabase/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,3 +270,9 @@ extraEnv: {}
# configMapKeyRef:
# name: metabase
# key: email

envFrom: []
# - type: secret
# name: metabase-secret
# - type: configMap
# name: metabase-cm
Loading