Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rt/jdj/rpd test correct answers #1368

Open
wants to merge 67 commits into
base: develop
Choose a base branch
from

Conversation

JacksonJ-KC
Copy link
Collaborator

Creating a draft pull request so that files can begin to be reviewed.

@JacksonJ-KC JacksonJ-KC self-assigned this May 28, 2024
@jugonzal07
Copy link
Contributor

@jugonzal07 I am noticing now that excel_to_test_json is behaving unexpectedly. I am seeing it is creating 5 HVAC systems (1 for each zone) even though the spreadsheet only has 1 baseline_system defined and all zones are defined as children to systems[0].

Can you help me look into this?

I can take a look into it. Feel free to email me the spreadsheet or setup that is giving you issues.

It depends on the system type. Systems that are single zone (e.g., zone equipment, PSZ systems) will duplicate themselves if they are assigned to multiple zones, even if they're all on the same systems[x] list. If it's one of those, then this is expected behavior-- at least with how the script was designed.

@JacksonJ-KC
Copy link
Collaborator Author

Thanks Juan, that was enough info for me to search for and find the "determine_system_classification" function and debug to figure out what was happening. All set!

@JacksonJ-KC JacksonJ-KC marked this pull request as ready for review June 14, 2024 20:20
@JacksonJ-KC
Copy link
Collaborator Author

@weilixu @jugonzal07 all test case RPDs are ready for review.. only 863,000 new lines to approve! 😂Most of it is schedules.

All RPDs are currently failing validation because the Infiltration Schedule is referenced but does not exist yet. It still needs to be defined in Table 12 of Standard 229.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants