Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rt/jdj/rpd test correct answers #1368

Open
wants to merge 67 commits into
base: develop
Choose a base branch
from
Open

Rt/jdj/rpd test correct answers #1368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
7035927
Added set_dict_from_json_file_template to excel_to_test_json_utilitie…
May 13, 2024
4d8cbac
Added logic to excel_to_test_json to account for scenarios when you h…
May 13, 2024
4652531
Added logic to "disaggregate_master_rmd_json" to create stripped down…
May 13, 2024
9f30705
begin base test building
JacksonJ-KC May 15, 2024
55fb6e3
work on constructions
JacksonJ-KC May 15, 2024
6969167
Fixed issue where final system assignment check was indented to wrong…
May 15, 2024
762f851
correct u-factors, surface optical properties
JacksonJ-KC May 22, 2024
e79733f
correct shgc, vt
JacksonJ-KC May 22, 2024
6e64e28
correct infiltration
JacksonJ-KC May 22, 2024
e9df70e
occupant heat gain
JacksonJ-KC May 23, 2024
9cf5e74
RPD Test System 1 Template
JacksonJ-KC May 23, 2024
e60b0ee
conditioning type
JacksonJ-KC May 23, 2024
d64790a
zone params
JacksonJ-KC May 23, 2024
18fcdd1
RPD Test PTHP
JacksonJ-KC May 23, 2024
3ce2d41
RPD Test PSZ AC
JacksonJ-KC May 23, 2024
6fa6c9d
RPD Test PSZ HP
JacksonJ-KC May 23, 2024
81f5ea5
correct terminal min oa
JacksonJ-KC May 24, 2024
c2b84cf
RPD Test PVAV HW Reheat
JacksonJ-KC May 24, 2024
9d1a37a
RPD Test PVAV Elec Reheat
JacksonJ-KC May 24, 2024
b0b49fc
add optical properties id
JacksonJ-KC Jun 7, 2024
7aa8a2c
validation updates
JacksonJ-KC Jun 7, 2024
79c6f62
validation updates
JacksonJ-KC Jun 7, 2024
57c683b
system 7 rpd test
JacksonJ-KC Jun 7, 2024
5d317b2
validation updates
JacksonJ-KC Jun 7, 2024
e072a9f
rpd test baseline system 8
JacksonJ-KC Jun 10, 2024
b5b17cd
corrections
JacksonJ-KC Jun 10, 2024
97aaf18
correct answer rpd baseline system 9
JacksonJ-KC Jun 10, 2024
1117b24
correct answer rpd baseline system 10
JacksonJ-KC Jun 10, 2024
304ac4e
add distribution effectiveness
JacksonJ-KC Jun 10, 2024
9226402
black format
JacksonJ-KC Jun 10, 2024
fc08e71
correct typos to pass validation
JacksonJ-KC Jun 10, 2024
eb0ccb6
correct answer rpd baseline system 11
JacksonJ-KC Jun 11, 2024
3162be9
correct answer rpd baseline system 12
JacksonJ-KC Jun 11, 2024
32603a1
corrections
JacksonJ-KC Jun 11, 2024
1f227de
correct answer rpd baseline system 13
JacksonJ-KC Jun 11, 2024
91e416d
corrections
JacksonJ-KC Jun 11, 2024
46f738d
validation updates
JacksonJ-KC Jun 11, 2024
6334bf3
validation updates
JacksonJ-KC Jun 11, 2024
24d2f8c
full rpds
JacksonJ-KC Jun 11, 2024
394c7a7
full rpds
JacksonJ-KC Jun 11, 2024
53eff91
added schedules
JacksonJ-KC Jun 11, 2024
5aa8089
correct answer RPD F test case 210
JacksonJ-KC Jun 12, 2024
45dbc47
correct answer RPD F test case 220
JacksonJ-KC Jun 12, 2024
268e719
correct return fan pressure rise
JacksonJ-KC Jun 14, 2024
197ef9d
correct multizone systems
JacksonJ-KC Jun 14, 2024
2bf3cfd
Test Case 3 correct answer RPD
JacksonJ-KC Jun 14, 2024
21355f5
correct sys2 min OA
JacksonJ-KC Jun 14, 2024
a967a92
add hw loop min flow fraction
JacksonJ-KC Jun 14, 2024
49fff5a
Test Case 230 correct answer RPD
JacksonJ-KC Jun 14, 2024
be91d3d
minor updates
JacksonJ-KC Jun 14, 2024
4e4f781
update to handle multiple terminals in a zone
JacksonJ-KC Jun 14, 2024
5f17452
Test Case 240 correct answer RPD
JacksonJ-KC Jun 14, 2024
3191c1a
optionally transfer system template zone data
JacksonJ-KC Jul 22, 2024
f85b505
address JG review comments
JacksonJ-KC Jul 22, 2024
c0c39b7
add adjacent_zone to int walls
JacksonJ-KC Aug 19, 2024
dbabce8
add adjacent_zone to int walls
JacksonJ-KC Aug 19, 2024
e177e59
correct zone volume
JacksonJ-KC Aug 19, 2024
df82860
correct surface areas
JacksonJ-KC Aug 20, 2024
033d66c
correct infiltration flow rates
JacksonJ-KC Sep 2, 2024
7f4cd81
correct simplified surface constructions
JacksonJ-KC Sep 2, 2024
e64b6cb
correct zone naming
JacksonJ-KC Sep 2, 2024
477a912
various rpd corrections
JacksonJ-KC Sep 3, 2024
2a85346
correct slab insulation density
JacksonJ-KC Sep 3, 2024
652a3b2
correct misc equipment power
JacksonJ-KC Sep 10, 2024
9b3e467
correct temp reset method
JacksonJ-KC Oct 9, 2024
4b9f1fb
correct chiller temps
JacksonJ-KC Oct 9, 2024
ed617b6
correct economizer integration
JacksonJ-KC Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45,231 changes: 45,231 additions & 0 deletions rct229/ruletest_engine/ruletest_jsons/ashrae9012019/full_rpds/F Test 100_baseline.json
View file
Open in desktop

Large diffs are not rendered by default.

45,216 changes: 45,216 additions & 0 deletions rct229/ruletest_engine/ruletest_jsons/ashrae9012019/full_rpds/F Test 110_baseline.json
View file
Open in desktop

Large diffs are not rendered by default.

45,236 changes: 45,236 additions & 0 deletions rct229/ruletest_engine/ruletest_jsons/ashrae9012019/full_rpds/F Test 120_baseline.json
View file
Open in desktop

Large diffs are not rendered by default.

45,109 changes: 45,109 additions & 0 deletions rct229/ruletest_engine/ruletest_jsons/ashrae9012019/full_rpds/F Test 130_baseline.json
View file
Open in desktop

Large diffs are not rendered by default.

45,069 changes: 45,069 additions & 0 deletions rct229/ruletest_engine/ruletest_jsons/ashrae9012019/full_rpds/F Test 140_baseline.json
View file
Open in desktop

Large diffs are not rendered by default.

45,143 changes: 45,143 additions & 0 deletions rct229/ruletest_engine/ruletest_jsons/ashrae9012019/full_rpds/F Test 150_baseline.json
View file
Open in desktop

Large diffs are not rendered by default.

45,206 changes: 45,206 additions & 0 deletions rct229/ruletest_engine/ruletest_jsons/ashrae9012019/full_rpds/F Test 160_baseline.json
View file
Open in desktop

Large diffs are not rendered by default.

45,131 changes: 45,131 additions & 0 deletions rct229/ruletest_engine/ruletest_jsons/ashrae9012019/full_rpds/F Test 170_baseline.json
View file
Open in desktop

Large diffs are not rendered by default.

45,308 changes: 45,308 additions & 0 deletions rct229/ruletest_engine/ruletest_jsons/ashrae9012019/full_rpds/F Test 180_baseline.json
View file
Open in desktop

Large diffs are not rendered by default.

45,339 changes: 45,339 additions & 0 deletions rct229/ruletest_engine/ruletest_jsons/ashrae9012019/full_rpds/F Test 190_baseline.json
View file
Open in desktop

Large diffs are not rendered by default.

45,253 changes: 45,253 additions & 0 deletions rct229/ruletest_engine/ruletest_jsons/ashrae9012019/full_rpds/F Test 200_baseline.json
View file
Open in desktop

Large diffs are not rendered by default.

45,278 changes: 45,278 additions & 0 deletions rct229/ruletest_engine/ruletest_jsons/ashrae9012019/full_rpds/F Test 210_baseline.json
View file
Open in desktop

Large diffs are not rendered by default.

45,227 changes: 45,227 additions & 0 deletions rct229/ruletest_engine/ruletest_jsons/ashrae9012019/full_rpds/F Test 220_baseline.json
View file
Open in desktop

Large diffs are not rendered by default.

45,279 changes: 45,279 additions & 0 deletions rct229/ruletest_engine/ruletest_jsons/ashrae9012019/full_rpds/F Test 230_baseline.json
View file
Open in desktop

Large diffs are not rendered by default.

45,372 changes: 45,372 additions & 0 deletions rct229/ruletest_engine/ruletest_jsons/ashrae9012019/full_rpds/F Test 240_baseline.json
View file
Open in desktop

Large diffs are not rendered by default.

45,296 changes: 45,296 additions & 0 deletions rct229/ruletest_engine/ruletest_jsons/ashrae9012019/full_rpds/Test Case 1_baseline.json
View file
Open in desktop

Large diffs are not rendered by default.

45,337 changes: 45,337 additions & 0 deletions rct229/ruletest_engine/ruletest_jsons/ashrae9012019/full_rpds/Test Case 2_baseline.json
View file
Open in desktop

Large diffs are not rendered by default.

45,109 changes: 45,109 additions & 0 deletions rct229/ruletest_engine/ruletest_jsons/ashrae9012019/full_rpds/Test Case 3_baseline.json
View file
Open in desktop

Large diffs are not rendered by default.

239 changes: 239 additions & 0 deletions ...letest_engine/ruletest_jsons/ashrae9012019/system_types/RPD_Test_System 12_CAV_SZ_HW.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,239 @@
{
"id": "ASHRAE229 1",
"ruleset_model_descriptions": [
{
"id": "RMD 1",
"buildings": [
{
"id": "Building 1",
"building_segments": [
{
"id": "Building Segment 1",
"zones": [
{
"id": "Thermal Zone 1",
"thermostat_cooling_setpoint_schedule": "Cooling Setpoint Schedule",
"thermostat_heating_setpoint_schedule": "Heating Setpoint Schedule",
"design_thermostat_cooling_setpoint": 23.9,
"design_thermostat_heating_setpoint": 21.1,
"air_distribution_effectiveness": 0.8,
"terminals": [
{
"id": "CAV Air Terminal 1",
"is_supply_ducted": true,
"type": "CONSTANT_AIR_VOLUME",
"served_by_heating_ventilating_air_conditioning_system": "System 12",
"primary_airflow": 943.9,
"supply_design_heating_setpoint_temperature": 32.2,
"supply_design_cooling_setpoint_temperature": 12.8,
"minimum_outdoor_airflow": 94.4
}
]
}
],
"heating_ventilating_air_conditioning_systems": [
{
"id": "System 12",
"cooling_system": {
"id": "CHW Coil 1",
"type": "FLUID_LOOP",
"chilled_water_loop": "CHW Loop 1",
"design_sensible_cool_capacity": 11723,
"rated_total_cool_capacity": 17584,
"is_sized_based_on_design_day": false
},
"heating_system": {
"id": "Boiler Coil 1",
"type": "FLUID_LOOP",
"hot_water_loop": "HW Loop 1",
"rated_capacity": 17584,
"design_capacity": 17000,
"is_sized_based_on_design_day": false
},
"fan_system": {
"id": "CAV Fan System 1",
"fan_control": "CONSTANT",
"operation_during_occupied": "CONTINUOUS",
"operation_during_unoccupied": "KEEP_OFF",
"supply_fans": [
{
"id": "Supply Fan 1",
"design_airflow": 943.9,
"is_airflow_sized_based_on_design_day": false,
"specification_method": "SIMPLE",
"design_electric_power": 600
}
],
"air_economizer": {
"id": "Air Economizer 1",
"type": "ENTHALPY",
"is_integrated": true
}
}
}
]
}
]
}
],
"boilers": [
{
"id": "Boiler 1",
"loop": "HW Loop 1",
"energy_source_type": "NATURAL_GAS",
"draft_type": "NATURAL",
"rated_capacity": 87921,
"efficiency_metric": "ANNUAL_FUEL_UTILIZATION",
"efficiency": 0.84,
"output_validation_points": [
{
"load": 0,
"entering_water_temperature": 54.4,
"result": 0
},
{
"load": 87921,
"entering_water_temperature": 54.4,
"result": 104668
}
]
}
],
"chillers": [
{
"id": "Chiller 1",
"cooling_loop": "CHW Loop 1",
"condensing_loop": "CW Loop 1",
"is_chilled_water_pump_interlocked": false,
"is_condenser_water_pump_interlocked": true,
"compressor_type": "SCREW",
"energy_source_type": "ELECTRICITY",
"design_capacity": 87921,
"rated_entering_condenser_temperature": 29.4,
"rated_leaving_evaporator_temperature": 10,
"part_load_efficiency": 0.5,
"part_load_efficiency_metric": "NONSTANDARD_PART_LOAD_VALUE",
"capacity_validation_points": [
{
"chilled_water_supply_temperature": 10,
"condenser_temperature": 24,
"result": 80000
},
{
"chilled_water_supply_temperature": 10,
"condenser_temperature": 29.4,
"result": 85000
}
],
"power_validation_points": [
{
"chilled_water_supply_temperature": 10,
"condenser_temperature": 29.4,
"load": 0,
"result": 0
},
{
"chilled_water_supply_temperature": 10,
"condenser_temperature": 29.4,
"load": 85000,
"result": 85000
}
]
}
],
"heat_rejections": [
{
"id": "Cooling Tower 1",
"loop": "CW Loop 1",
"type": "CLOSED_CIRCUIT_COOLING_TOWER",
"fan_type": "AXIAL",
"fluid": "WATER",
"range": 5.6,
"approach": 3.9,
"design_wetbulb_temperature": 25,
"leaving_water_setpoint_temperature": 21.1,
"rated_water_flowrate": 4.73,
"fan_speed_control": "TWO_SPEED"
}
],
"pumps": [
{
"id": "Boiler Pump 1",
"loop_or_piping": "HW Loop 1",
"speed_control": "VARIABLE_SPEED",
"specification_method": "SIMPLE",
"design_electric_power": 380,
"design_flow": 1.26,
"is_flow_sized_based_on_design_day": false
},
{
"id": "Chiller Pump 1",
"loop_or_piping": "CHW Loop 1",
"speed_control": "VARIABLE_SPEED",
"specification_method": "SIMPLE",
"design_electric_power": 1320,
"design_flow": 3.79,
"is_flow_sized_based_on_design_day": false
},
{
"id": "Condenser Pump 1",
"loop_or_piping": "CW Loop 1",
"speed_control": "VARIABLE_SPEED",
"specification_method": "SIMPLE",
"design_electric_power": 1425,
"design_flow": 4.73,
"is_flow_sized_based_on_design_day": false
}
],
"fluid_loops": [
{
"id": "HW Loop 1",
"type": "HEATING",
"pump_power_per_flow_rate": 301,
"heating_design_and_control": {
"id": "HW Design and Control",
"design_supply_temperature": 82.2,
"design_return_temperature": 54.4,
"outdoor_high_for_loop_supply_reset_temperature": 10,
"outdoor_low_for_loop_supply_reset_temperature": -6.7,
"loop_supply_temperature_at_outdoor_high": 65.6,
"loop_supply_temperature_at_outdoor_low": 82.2,
"is_sized_using_coincident_load": true,
"operation": "CONTINUOUS",
"flow_control": "VARIABLE_FLOW"
}
},
{
"id": "CHW Loop 1",
"type": "COOLING",
"pump_power_per_flow_rate": 349,
"cooling_or_condensing_design_and_control": {
"id": "Primary CHW Design and Control",
"design_supply_temperature": 6.7,
"design_return_temperature": 12.8,
"outdoor_high_for_loop_supply_reset_temperature": 26.7,
"outdoor_low_for_loop_supply_reset_temperature": 15.6,
"loop_supply_temperature_at_outdoor_high": 6.7,
"loop_supply_temperature_at_outdoor_low": 12.2,
"is_sized_using_coincident_load": true,
"operation": "CONTINUOUS",
"flow_control": "VARIABLE_FLOW",
"temperature_reset_type": "OUTSIDE_AIR_RESET"
}
},
{
"id": "CW Loop 1",
"type": "CONDENSER",
"pump_power_per_flow_rate": 301,
"cooling_or_condensing_design_and_control": {
"id": "CW Design and Control",
"design_supply_temperature": 21.1,
"is_sized_using_coincident_load": true,
"operation": "CONTINUOUS",
"flow_control": "VARIABLE_FLOW"
}
}
]
}
]
}
149 changes: 149 additions & 0 deletions ...letest_engine/ruletest_jsons/ashrae9012019/system_types/RPD_Test_System 13_CAV_SZ_ER.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,149 @@
{
"id": "ASHRAE229 1",
"ruleset_model_descriptions": [
{
"id": "RMD 1",
"buildings": [
{
"id": "Building 1",
"building_segments": [
{
"id": "Building Segment 1",
"zones": [
{
"id": "Thermal Zone 1",
"thermostat_cooling_setpoint_schedule": "Cooling Setpoint Schedule",
"thermostat_heating_setpoint_schedule": "Heating Setpoint Schedule",
"design_thermostat_cooling_setpoint": 23.9,
"design_thermostat_heating_setpoint": 21.1,
"air_distribution_effectiveness": 0.8,
"terminals": [
{
"id": "CAV Air Terminal 1",
"is_supply_ducted": true,
"type": "CONSTANT_AIR_VOLUME",
"served_by_heating_ventilating_air_conditioning_system": "System 13",
"primary_airflow": 943.9,
"supply_design_heating_setpoint_temperature": 32.2,
"supply_design_cooling_setpoint_temperature": 12.8,
"minimum_outdoor_airflow": 94.4
}
]
}
],
"heating_ventilating_air_conditioning_systems": [
{
"id": "System 13",
"cooling_system": {
"id": "CHW Coil 1",
"type": "FLUID_LOOP",
"chilled_water_loop": "CHW Loop 1",
"design_sensible_cool_capacity": 11723,
"rated_total_cool_capacity": 17584,
"is_sized_based_on_design_day": false
},
"heating_system": {
"id": "Heating Coil 1",
"type": "ELECTRIC_RESISTANCE",
"rated_capacity": 17584,
"design_capacity": 17000,
"efficiency_metric_values": [1],
"efficiency_metric_types": ["THERMAL_EFFICIENCY"],
"is_sized_based_on_design_day": false
},
"fan_system": {
"id": "CAV Fan System 1",
"fan_control": "CONSTANT",
"operation_during_occupied": "CONTINUOUS",
"operation_during_unoccupied": "KEEP_OFF",
"supply_fans": [
{
"id": "Supply Fan 1",
"design_airflow": 943.9,
"is_airflow_sized_based_on_design_day": false,
"specification_method": "SIMPLE",
"design_electric_power": 600
}
]
}
}
]
}
]
}
],
"chillers": [
{
"id": "Chiller 1",
"cooling_loop": "CHW Loop 1",
"is_chilled_water_pump_interlocked": false,
"is_condenser_water_pump_interlocked": true,
"compressor_type": "SCREW",
"energy_source_type": "ELECTRICITY",
"design_capacity": 87921,
"rated_entering_condenser_temperature": 29.4,
"rated_leaving_evaporator_temperature": 10,
"part_load_efficiency": 0.5,
"part_load_efficiency_metric": "NONSTANDARD_PART_LOAD_VALUE",
"capacity_validation_points": [
{
"chilled_water_supply_temperature": 10,
"condenser_temperature": 24,
"result": 80000
},
{
"chilled_water_supply_temperature": 10,
"condenser_temperature": 29.4,
"result": 85000
}
],
"power_validation_points": [
{
"chilled_water_supply_temperature": 10,
"condenser_temperature": 29.4,
"load": 0,
"result": 0
},
{
"chilled_water_supply_temperature": 10,
"condenser_temperature": 29.4,
"load": 85000,
"result": 85000
}
]
}
],
"pumps": [
{
"id": "Chiller Pump 1",
"loop_or_piping": "CHW Loop 1",
"speed_control": "VARIABLE_SPEED",
"specification_method": "SIMPLE",
"design_electric_power": 1320,
"design_flow": 3.79,
"is_flow_sized_based_on_design_day": false
}
],
"fluid_loops": [
{
"id": "CHW Loop 1",
"type": "COOLING",
"pump_power_per_flow_rate": 349,
"cooling_or_condensing_design_and_control": {
"id": "Primary CHW Design and Control",
"design_supply_temperature": 6.7,
"design_return_temperature": 12.8,
"outdoor_high_for_loop_supply_reset_temperature": 26.7,
"outdoor_low_for_loop_supply_reset_temperature": 15.6,
"loop_supply_temperature_at_outdoor_high": 6.7,
"loop_supply_temperature_at_outdoor_low": 12.2,
"is_sized_using_coincident_load": true,
"operation": "CONTINUOUS",
"flow_control": "VARIABLE_FLOW",
"temperature_reset_type": "OUTSIDE_AIR_RESET"
}
}
]
}
]
}
Loading