RS/JDJ/Rule19-10 Bug Fix #1458
Merged
RS/JDJ/Rule19-10 Bug Fix #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weilixu
reviewed
Aug 5, 2024
| "fan_air_economizer_type_b": fan_air_economizer_type_b, | ||
| "fan_air_economizer_type_p": fan_air_economizer_type_p, | ||
| "HVAC_systems_primarily_serving_comp_rooms_list": HVAC_systems_primarily_serving_comp_rooms_list, |
There was a problem hiding this comment.
Is the reason to add proposed data because we do not have is_economizer_modeled_in_proposed function?
There was a problem hiding this comment.
This was my proposed solution to reach this case of the RDS https://github.com/pnnl/ruleset-checking-tool/blob/develop/docs/section19/Rule19-10.md?plain=1#L55
I think is_economizer_modeled_in_proposed could probably be used too
weilixu
changed the base branch from
develop
to
RT/JG/ruletest_na_undetermined_fix
JacksonJ-KC
merged commit 36c5ebc
into
RT/JG/ruletest_na_undetermined_fix
2 checks passed
|
Github says 'Merged' but the changes of this PR have not been merged into RT/JG/ruletest_na_undetermined_fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will be needed for #1422