Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RS/JDJ/Rule19-10 Bug Fix #1458

Merged
merged 1 commit into from
Aug 5, 2024
Merged

RS/JDJ/Rule19-10 Bug Fix #1458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 30 additions & 21 deletions rct229/rulesets/ashrae9012019/section19/section19rule10.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ def is_applicable(self, context, data=None):

def get_calc_vals(self, context, data=None):
hvac_b = context.BASELINE_0
hvac_p = context.PROPOSED
hvac_id_b = hvac_b["id"]

baseline_system_types_dict = data["baseline_system_types_dict"]
Expand All @@ -169,53 +170,61 @@ def get_calc_vals(self, context, data=None):
baseline_system_types_b = sys_type

fan_sys_b = hvac_b["fan_system"]
fan_sys_p = hvac_p["fan_system"]
fan_air_economizer_b = find_one("$.air_economizer", fan_sys_b)
fan_air_economizer_p = find_one("$.air_economizer", fan_sys_p)
fan_air_economizer_type_b = find_one("$.air_economizer.type", fan_sys_b)
fan_air_economizer_type_p = find_one("$.air_economizer.type", fan_sys_p)

return {
"hvac_id_b": hvac_id_b,
"baseline_system_types_b": baseline_system_types_b,
"fan_air_economizer_b": fan_air_economizer_b,
"fan_air_economizer_p": fan_air_economizer_p,
"fan_air_economizer_type_b": fan_air_economizer_type_b,
"fan_air_economizer_type_p": fan_air_economizer_type_p,
"HVAC_systems_primarily_serving_comp_rooms_list": HVAC_systems_primarily_serving_comp_rooms_list,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the reason to add proposed data because we do not have is_economizer_modeled_in_proposed function?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my proposed solution to reach this case of the RDS https://github.com/pnnl/ruleset-checking-tool/blob/develop/docs/section19/Rule19-10.md?plain=1#L55

I think is_economizer_modeled_in_proposed could probably be used too

}

def manual_check_required(self, context, calc_vals=None, data=None):
hvac_id_b = calc_vals["hvac_id_b"]
hvac_system_exception_2_list = data["hvac_system_exception_2_list"]
return hvac_id_b in hvac_system_exception_2_list

def get_manual_check_required_msg(self, context, calc_vals=None, data=None):
hvac_id_b = calc_vals["hvac_id_b"]
fan_air_economizer_b = calc_vals["fan_air_economizer_b"]
fan_air_economizer_p = calc_vals["fan_air_economizer_p"]
fan_air_economizer_type_b = calc_vals["fan_air_economizer_type_b"]
fan_air_economizer_type_p = calc_vals["fan_air_economizer_type_p"]
hvac_system_exception_2_list = data["hvac_system_exception_2_list"]

return (
if (
(
fan_air_economizer_p is None
or fan_air_economizer_type_p
in [None, AIR_ECONOMIZER.FIXED_FRACTION]
)
and (
fan_air_economizer_b is None
or fan_air_economizer_type_b
in [None, AIR_ECONOMIZER.FIXED_FRACTION]
)
and hvac_id_b in hvac_system_exception_2_list
) or (
fan_air_economizer_b is not None
and fan_air_economizer_type_b != AIR_ECONOMIZER.FIXED_FRACTION
and hvac_id_b in hvac_system_exception_2_list
)

def get_manual_check_required_msg(self, context, calc_vals=None, data=None):
hvac_id_b = calc_vals["hvac_id_b"]
baseline_system_types_b = calc_vals["baseline_system_types_b"]
fan_air_economizer_b = calc_vals["fan_air_economizer_b"]
fan_air_economizer_type_b = calc_vals["fan_air_economizer_type_b"]
hvac_system_exception_2_list = data["hvac_system_exception_2_list"]

if (
fan_air_economizer_b is None
or fan_air_economizer_type_b
in [None, AIR_ECONOMIZER.FIXED_FRACTION]
) and baseline_system_types_b in hvac_system_exception_2_list:
):
# Case 2 msg
undetermined_msg = f"Undetermined unless any of the zones served by the baseline system {hvac_id_b} in the proposed design include supermarket open refrigerated case-work systems that will be affected by using outdoor air for cooling (G3.1.2.6 exception #2)."
elif (
fan_air_economizer_b is not None
and fan_air_economizer_type_b != AIR_ECONOMIZER.FIXED_FRACTION
(
fan_air_economizer_p is None
or fan_air_economizer_type_p
in [None, AIR_ECONOMIZER.FIXED_FRACTION]
)
and (
fan_air_economizer_b is not None
and fan_air_economizer_type_b
not in [None, AIR_ECONOMIZER.FIXED_FRACTION]
)
and hvac_id_b in hvac_system_exception_2_list
):
# Case 4 msg
Expand Down
Loading