-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rule Test 11-6 #1522
base: develop
Are you sure you want to change the base?
Rule Test 11-6 #1522
Changes from all commits
6173f28
ce9e82b
05909ea
3cf0ef4
962ee32
35fc2ef
36b1f34
d0132a8
c29b727
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,143 @@ | ||
{ | ||
"rule-11-6-a": { | ||
"Section": 11, | ||
"Rule": 6, | ||
"Test": "a", | ||
"test_description": "A one story, single zone building has service hot water piping. The service hot water piping losses are correctly not modeled.", | ||
"expected_rule_outcome": "pass", | ||
"standard": { | ||
"rule_id": "11-6", | ||
"ruleset_reference": "Table G3.1 #11, baseline column, i", | ||
"rule_description": "Piping losses shall not be modeled.", | ||
"applicable_rmr": "Baseline Model", | ||
"rule_assertion": "=", | ||
"comparison_value": "Expected Value", | ||
"mandatory_rule": "Yes", | ||
"schema_version": "0.0.34" | ||
}, | ||
"rmd_transformations": { | ||
"baseline": { | ||
"id": "ASHRAE229 1", | ||
"calendar": { | ||
"is_leap_year": false | ||
}, | ||
"data_timestamp": "2024-02-12T12:00Z", | ||
"ruleset_model_descriptions": [ | ||
{ | ||
"id": "RMD 1", | ||
"buildings": [ | ||
{ | ||
"id": "Building 1", | ||
"building_segments": [ | ||
{ | ||
"id": "Building Segment 1", | ||
"zones": [ | ||
{ | ||
"id": "Thermal Zone 1", | ||
"floor_name": "Floor1", | ||
"spaces": [ | ||
{ | ||
"id": "Space 1", | ||
"service_water_heating_uses": [ | ||
{ | ||
"id": "SHW 1", | ||
"served_by_distribution_system": "SHW Distribution 1" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe the value of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi Yun Joon, The schema seems to indicate that this should match with a Let me know if this complicates things on you all's end, but I believe this implementation is correct. Let me know if you all think overwise. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Juan, You're right. Thank you for pointing this out. I'll correct the 11-6 rule. |
||
} | ||
] | ||
} | ||
] | ||
} | ||
] | ||
} | ||
] | ||
} | ||
], | ||
"service_water_heating_distribution_systems": [ | ||
{ | ||
"id": "SHW Distribution 1", | ||
"service_water_piping": [ | ||
{ | ||
"id": "SHW Piping 1", | ||
"are_thermal_losses_modeled": false | ||
} | ||
] | ||
} | ||
], | ||
"type": "BASELINE_0" | ||
} | ||
] | ||
} | ||
} | ||
}, | ||
"rule-11-6-b": { | ||
"Section": 11, | ||
"Rule": 6, | ||
"Test": "b", | ||
"test_description": "A one story, single zone building has service hot water piping. The service hot water piping losses are modeled.", | ||
"expected_rule_outcome": "fail", | ||
"standard": { | ||
"rule_id": "11-6", | ||
"ruleset_reference": "Table G3.1 #11, baseline column, i", | ||
"rule_description": "Piping losses shall not be modeled.", | ||
"applicable_rmr": "Baseline Model", | ||
"rule_assertion": "=", | ||
"comparison_value": "Expected Value", | ||
"mandatory_rule": "Yes", | ||
"schema_version": "0.0.34" | ||
}, | ||
"rmd_transformations": { | ||
"baseline": { | ||
"id": "ASHRAE229 1", | ||
"calendar": { | ||
"is_leap_year": false | ||
}, | ||
"data_timestamp": "2024-02-12T12:00Z", | ||
"ruleset_model_descriptions": [ | ||
{ | ||
"id": "RMD 1", | ||
"buildings": [ | ||
{ | ||
"id": "Building 1", | ||
"building_segments": [ | ||
{ | ||
"id": "Building Segment 1", | ||
"zones": [ | ||
{ | ||
"id": "Thermal Zone 1", | ||
"floor_name": "Floor1", | ||
"spaces": [ | ||
{ | ||
"id": "Space 1", | ||
"service_water_heating_space_type": "OFFICE", | ||
"service_water_heating_uses": [ | ||
{ | ||
"id": "SHW 1", | ||
"served_by_distribution_system": "SHW Distribution 1" | ||
} | ||
] | ||
} | ||
] | ||
} | ||
] | ||
} | ||
] | ||
} | ||
], | ||
"service_water_heating_distribution_systems": [ | ||
{ | ||
"id": "SHW Distribution 1", | ||
"service_water_piping": [ | ||
{ | ||
"id": "SHW Piping 1", | ||
"are_thermal_losses_modeled": true | ||
} | ||
] | ||
} | ||
], | ||
"type": "BASELINE_0" | ||
} | ||
] | ||
} | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we need the
service_water_heating_uses
key here (please see Jiarong's PR- https://github.com/pnnl/ruleset-checking-tool/pull/1511/files#diff-9214518a5c95ad02287645995653e70e7c6ee9b0f68a9bd81bfb8d27c68d47bb:~:text=%3A%20%22Space%201%22%2C-,%22service_water_heating_uses%22%3A%20%5B,-%7B%22id%22%3A%20%22service).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, thanks Yun Joon. The service water heating distribution should now be linked for the space