Rule Test 11-6 #1522
Rule Test 11-6 #1522
Conversation
jugonzal07
requested review from
weilixu,
yunjoonjung-PNNL and
Jiarongx-Xie
| "floor_name": "Floor1", | ||
| "spaces": [ | ||
| { | ||
| "id": "Space 1", |
There was a problem hiding this comment.
I believe we need the service_water_heating_uses key here (please see Jiarong's PR- https://github.com/pnnl/ruleset-checking-tool/pull/1511/files#diff-9214518a5c95ad02287645995653e70e7c6ee9b0f68a9bd81bfb8d27c68d47bb:~:text=%3A%20%22Space%201%22%2C-,%22service_water_heating_uses%22%3A%20%5B,-%7B%22id%22%3A%20%22service).
There was a problem hiding this comment.
Great catch, thanks Yun Joon. The service water heating distribution should now be linked for the space
Indentation fix
# Conflicts: # rct229/schema/ASHRAE229.schema.json
…ace for 11-6 rule test
| "service_water_heating_uses": [ | ||
| { | ||
| "id": "SHW 1", | ||
| "served_by_distribution_system": "SHW Distribution 1" |
There was a problem hiding this comment.
I believe the value of served_by_distribution_system should be the same as the value of the id under the service_water_piping. Could you check?
There was a problem hiding this comment.
Hi Yun Joon,
The schema seems to indicate that this should match with a ServiceWaterHeatingDistributionSystem and not a
ServiceWaterPiping
Let me know if this complicates things on you all's end, but I believe this implementation is correct. Let me know if you all think overwise.
There was a problem hiding this comment.
Juan, You're right. Thank you for pointing this out. I'll correct the 11-6 rule.
| "service_water_piping": [ | ||
| { | ||
| "id": "SHW Piping 1", | ||
| "are_thermal_losses_modeled": true |
There was a problem hiding this comment.
Can you flip the case (a) and (b)'s boolean value? This is because False is pass and True is fail, as shown bottom of the 11-6 RDS (https://github.com/pnnl/ruleset-checking-tool/blob/develop/docs/section11/Rule11-6.md#:~:text=Case1%3A%20piping%20losses%20are%20not%20modeled%2C%20PASS%3A%20if%20!piping_losses_modeled%3A%20PASS)
There was a problem hiding this comment.
bah! Yes, I got them mixed up. Thanks Yun Joon. I will add that in my next push.
First cut at rule test 11-6