Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule Test 11-6 #1522

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Original file line number Diff line number Diff line change
@@ -0,0 +1,131 @@
{
"rule-11-6-a": {
"Section": 11,
"Rule": 6,
"Test": "a",
"test_description": "A one story building, single zone building has service hot water piping. The service hot water piping losses are correctly modeled.",
"expected_rule_outcome": "pass",
"standard": {
"rule_id": "11-6",
"ruleset_reference": "Table G3.1 #11, baseline column, i",
"rule_description": "Piping losses shall not be modeled.",
"applicable_rmr": "Baseline Model",
"rule_assertion": "=",
"comparison_value": "Expected Value",
"mandatory_rule": "No",
"schema_version": "0.0.34"
},
"rmd_transformations": {
"baseline": {
"id": "ASHRAE229 1",
"calendar": {
"is_leap_year": false
},
"data_timestamp": "2024-02-12T12:00Z",
"ruleset_model_descriptions": [
{
"id": "RMD 1",
"buildings": [
{
"id": "Building 1",
"building_segments": [
{
"id": "Building Segment 1",
"zones": [
{
"id": "Thermal Zone 1",
"floor_name": "Floor1",
"spaces": [
{
"id": "Space 1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@jugonzal07 jugonzal07 Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks Yun Joon. The service water heating distribution should now be linked for the space

"floor_area": 929.0303999999999
}
]
}
]
}
]
}
],
"service_water_heating_distribution_systems": [
{
"id": "SHW 1",
"service_water_piping": [
{
"id": "SHW Piping 1",
"are_thermal_losses_modeled": true
Copy link
Collaborator

@yunjoonjung-PNNL yunjoonjung-PNNL Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you flip the case (a) and (b)'s boolean value? This is because False is pass and True is fail, as shown bottom of the 11-6 RDS (https://github.com/pnnl/ruleset-checking-tool/blob/develop/docs/section11/Rule11-6.md#:~:text=Case1%3A%20piping%20losses%20are%20not%20modeled%2C%20PASS%3A%20if%20!piping_losses_modeled%3A%20PASS)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bah! Yes, I got them mixed up. Thanks Yun Joon. I will add that in my next push.

}
]
}
],
"type": "BASELINE_0"
}
]
}
}
},
"rule-11-6-b": {
"Section": 11,
"Rule": 6,
"Test": "b",
"test_description": "A one story building, single zone building has service hot water piping. The service hot water piping losses are not modeled.",
"expected_rule_outcome": "fail",
"standard": {
"rule_id": "11-6",
"ruleset_reference": "Table G3.1 #11, baseline column, i",
"rule_description": "Piping losses shall not be modeled.",
"applicable_rmr": "Baseline Model",
"rule_assertion": "=",
"comparison_value": "Expected Value",
"mandatory_rule": "No",
"schema_version": "0.0.34"
},
"rmd_transformations": {
"baseline": {
"id": "ASHRAE229 1",
"calendar": {
"is_leap_year": false
},
"data_timestamp": "2024-02-12T12:00Z",
"ruleset_model_descriptions": [
{
"id": "RMD 1",
"buildings": [
{
"id": "Building 1",
"building_segments": [
{
"id": "Building Segment 1",
"zones": [
{
"id": "Thermal Zone 1",
"floor_name": "Floor1",
"spaces": [
{
"id": "Space 1"
}
]
}
]
}
]
}
],
"service_water_heating_distribution_systems": [
{
"id": "SHW 1",
"service_water_piping": [
{
"id": "SHW Piping 1",
"are_thermal_losses_modeled": false
}
]
}
],
"type": "BASELINE_0"
}
]
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@
"output_validation_points": "ruleset_model_descriptions[0]/buildings[0]/building_segments[0]/zones[0]/terminals[0]/fan/output_validation_points",
"preheat_system": "ruleset_model_descriptions[0]/buildings[0]/building_segments[0]/heating_ventilating_air_conditioning_systems[0]/preheat_system",
"pumps": "ruleset_model_descriptions[0]/pumps",
"sensible_cool_capacity": "ruleset_model_descriptions[0]/buildings[0]/building_segments[0]/heating_ventilating_air_conditioning_systems[0]/cooling_system/sensible_cool_capacity",
"schedules": "ruleset_model_descriptions[0]/schedules",
"sensible_cool_capacity": "ruleset_model_descriptions[0]/buildings[0]/building_segments[0]/heating_ventilating_air_conditioning_systems[0]/cooling_system/sensible_cool_capacity",
"service_water_heating_distribution_systems": "ruleset_model_descriptions[0]/service_water_heating_distribution_systems",
"service_water_piping":"ruleset_model_descriptions[0]/service_water_heating_distribution_systems[0]/service_water_piping",
"spaces": "ruleset_model_descriptions[0]/buildings[0]/building_segments[0]/zones[0]/spaces",
"subsurfaces": "ruleset_model_descriptions[0]/buildings[0]/building_segments[0]/zones[0]/surfaces[0]/subsurfaces",
"surfaces": "ruleset_model_descriptions[0]/buildings[0]/building_segments[0]/zones[0]/surfaces",
Expand Down
4 changes: 4 additions & 0 deletions rct229/schema/ASHRAE229.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -4225,6 +4225,10 @@
"is_recirculation_loop": {
"description": "Indicates if service water heating piping is a loop and recirculates",
"type": "boolean"
},
jugonzal07 marked this conversation as resolved.
Show resolved Hide resolved
"are_thermal_losses_modeled": {
"description": "Indicates if thermal losses from the service water heating piping are modeled",
"type": "boolean"
},
"insulation_thickness": {
"description": "Pipe insulation thickness",
Expand Down
Loading