Rule Test 11-6 #1522
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,142 @@ | ||
| { | ||
| "rule-11-6-a": { | ||
| "Section": 11, | ||
| "Rule": 6, | ||
| "Test": "a", | ||
| "test_description": "A one story building, single zone building has service hot water piping. The service hot water piping losses are correctly modeled.", | ||
| "expected_rule_outcome": "pass", | ||
| "standard": { | ||
| "rule_id": "11-6", | ||
| "ruleset_reference": "Table G3.1 #11, baseline column, i", | ||
| "rule_description": "Piping losses shall not be modeled.", | ||
| "applicable_rmr": "Baseline Model", | ||
| "rule_assertion": "=", | ||
| "comparison_value": "Expected Value", | ||
| "mandatory_rule": "No", | ||
| "schema_version": "0.0.34" | ||
| }, | ||
| "rmd_transformations": { | ||
| "baseline": { | ||
| "id": "ASHRAE229 1", | ||
| "calendar": { | ||
| "is_leap_year": false | ||
| }, | ||
| "data_timestamp": "2024-02-12T12:00Z", | ||
| "ruleset_model_descriptions": [ | ||
| { | ||
| "id": "RMD 1", | ||
| "buildings": [ | ||
| { | ||
| "id": "Building 1", | ||
| "building_segments": [ | ||
| { | ||
| "id": "Building Segment 1", | ||
| "zones": [ | ||
| { | ||
| "id": "Thermal Zone 1", | ||
| "floor_name": "Floor1", | ||
| "spaces": [ | ||
| { | ||
| "id": "Space 1", | ||
| "service_water_heating_uses": [ | ||
| { | ||
| "id": "SHW 1", | ||
| "served_by_distribution_system": "SHW Distribution 1" | ||
|
There was a problem hiding this comment. I believe the value of There was a problem hiding this comment. Hi Yun Joon, The schema seems to indicate that this should match with a Let me know if this complicates things on you all's end, but I believe this implementation is correct. Let me know if you all think overwise. There was a problem hiding this comment. Juan, You're right. Thank you for pointing this out. I'll correct the 11-6 rule. |
||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "service_water_heating_distribution_systems": [ | ||
| { | ||
| "id": "SHW Distribution 1", | ||
| "service_water_piping": [ | ||
| { | ||
| "id": "SHW Piping 1", | ||
| "are_thermal_losses_modeled": true | ||
|
There was a problem hiding this comment. Can you flip the case (a) and (b)'s boolean value? This is because False is There was a problem hiding this comment. bah! Yes, I got them mixed up. Thanks Yun Joon. I will add that in my next push. |
||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "type": "BASELINE_0" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "rule-11-6-b": { | ||
| "Section": 11, | ||
| "Rule": 6, | ||
| "Test": "b", | ||
| "test_description": "A one story building, single zone building has service hot water piping. The service hot water piping losses are not modeled.", | ||
| "expected_rule_outcome": "fail", | ||
| "standard": { | ||
| "rule_id": "11-6", | ||
| "ruleset_reference": "Table G3.1 #11, baseline column, i", | ||
| "rule_description": "Piping losses shall not be modeled.", | ||
| "applicable_rmr": "Baseline Model", | ||
| "rule_assertion": "=", | ||
| "comparison_value": "Expected Value", | ||
| "mandatory_rule": "No", | ||
| "schema_version": "0.0.34" | ||
| }, | ||
| "rmd_transformations": { | ||
| "baseline": { | ||
| "id": "ASHRAE229 1", | ||
| "calendar": { | ||
| "is_leap_year": false | ||
| }, | ||
| "data_timestamp": "2024-02-12T12:00Z", | ||
| "ruleset_model_descriptions": [ | ||
| { | ||
| "id": "RMD 1", | ||
| "buildings": [ | ||
| { | ||
| "id": "Building 1", | ||
| "building_segments": [ | ||
| { | ||
| "id": "Building Segment 1", | ||
| "zones": [ | ||
| { | ||
| "id": "Thermal Zone 1", | ||
| "floor_name": "Floor1", | ||
| "spaces": [ | ||
| { | ||
| "id": "Space 1", | ||
| "service_water_heating_uses": [ | ||
| { | ||
| "id": "SHW 1", | ||
| "served_by_distribution_system": "SHW Distribution 1" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "service_water_heating_distribution_systems": [ | ||
| { | ||
| "id": "SHW Distribution 1", | ||
| "service_water_piping": [ | ||
| { | ||
| "id": "SHW Piping 1", | ||
| "are_thermal_losses_modeled": false | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "type": "BASELINE_0" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we need the
service_water_heating_useskey here (please see Jiarong's PR- https://github.com/pnnl/ruleset-checking-tool/pull/1511/files#diff-9214518a5c95ad02287645995653e70e7c6ee9b0f68a9bd81bfb8d27c68d47bb:~:text=%3A%20%22Space%201%22%2C-,%22service_water_heating_uses%22%3A%20%5B,-%7B%22id%22%3A%20%22service).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, thanks Yun Joon. The service water heating distribution should now be linked for the space