feat(HMS-3914): harden Dockerfile #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Add .podman .docker and .kube directories to .dockerignore Add '*.log' to the ignored files. Signed-off-by: Alejandro Visiedo <[email protected]>
avisiedo
force-pushed
the
hms-3914-harden-dockerfile
branch
from
36bcdf1
to
e56396c
Compare
|
I don't know if this change can break something. It doesn't seem covered by CI tests on GitLab what would be the commands to verify it is correct? |
|
Updating PR description as it is a bit different from the initial idea. |
|
yolo... if it breaks the build we revert it :) |
frasertweedale
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add default known directories to be ignored on
.dockerignorethat could have sensible information..docker,.podmanand.kube.*.log