feat: Implement a streaming merge sorted node #20960
Merged
+555
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
coastalwhite
force-pushed
the
feat/streaming-merge-sorted
branch
from
c6049f1 to
52632d1
Compare
coastalwhite
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
41 tasks
orlp
requested changes
Jan 30, 2025
coastalwhite
force-pushed
the
feat/streaming-merge-sorted
branch
from
374cfdf to
ea36e6d
Compare
coastalwhite
commented
Jan 31, 2025
| @@ -156,7 +156,7 @@ impl SeriesTrait for SeriesWrap<TimeChunked> { | |||
| } | |||
| fn split_at(&self, offset: i64) -> (Series, Series) { | |||
| let (a, b) = self.0.split_at(offset); | |||
| (a.into_series(), b.into_series()) | |||
There was a problem hiding this comment.
Drive by: this was producing wrong results for split_at
coastalwhite
commented
Jan 31, 2025
| @@ -16,6 +16,11 @@ pub fn get_ideal_morsel_size() -> usize { | |||
| }) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
drive-by: some docs for MorselSeq
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20960 +/- ##
==========================================
+ Coverage 79.14% 79.24% +0.10%
==========================================
Files 1583 1583
Lines 225119 225388 +269
Branches 2581 2581
==========================================
+ Hits 178162 178613 +451
+ Misses 46367 46185 -182
Partials 590 590 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.