-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement a streaming merge sorted node #20960
Merged
ritchie46
merged 10 commits into
pola-rs:main
from
coastalwhite:feat/streaming-merge-sorted
Feb 1, 2025
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5fde2f0
feat: Implement a streaming merge sorted node
coastalwhite 5b56307
two state system
coastalwhite aaf6612
mostly working
coastalwhite 9431d12
finalize
coastalwhite e40ab70
lints
coastalwhite e6932e8
no more phase transitions for merge sorted
coastalwhite ea36e6d
fix some more bugs
coastalwhite 971d43f
typos
coastalwhite 99bc067
remove prints, oops
coastalwhite 6396ca5
typos again
coastalwhite File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,11 @@ pub fn get_ideal_morsel_size() -> usize { | |
}) | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. drive-by: some docs for MorselSeq |
||
/// A token indicating the order of morsels in a stream. | ||
/// | ||
/// The sequence tokens going through a pipe are monotonely non-decreasing and are allowed to be | ||
/// discontinuous. Consequently, `1 -> 1 -> 2` and `1 -> 3 -> 5` are valid streams of sequence | ||
/// tokens. | ||
#[derive(Copy, Clone, Eq, PartialEq, Ord, PartialOrd, Debug, Default)] | ||
pub struct MorselSeq(u64); | ||
|
||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive by: this was producing wrong results for split_at