Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the assets of data store and source to Polypheny-DB #93

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

malikrafsan
Copy link

Summary

In this pull request, we move the logos from stored at the Frontend (Polypheny-UI) to the Backend (Polypheny-DB). We also add the logo path/icon identifier on the response regarding Data Store and Data Source (/getSnapshot). By doing this, we can simplify the process of adding new Data Stores / Data Sources by storing the logos in Polypheny-DB sources together with the adapter implementation.

Fixes: #222

Changes

  • Add adapterLogo attribute on AdapterProperties annotation interface
  • Send adapterLogo attribute with existing adapter information
  • Change Polypheny-UI logic regarding adapterLogo

Related PRs


Screenshots

  • Asset files can be served by Polypheny-DB, under /public hosted path
    Screenshot from 2024-04-05 00-59-49

  • Polypheny-UI can access the Polypheny-DB static files and the Data Source and Data Store logos are shown successfully
    Screenshot from 2024-04-05 01-02-00

@malikrafsan malikrafsan marked this pull request as ready for review April 10, 2024 12:57
@malikrafsan
Copy link
Author

Hi @vogti I am sorry I think previous PR cannot be editted regarding the target branch. Therefore, I think we need to open a new PR. I would be more than happy to get your feedback, thank you so much!!

Copy link
Member

@datomo datomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @malikrafsan, this looks good.
After updating the branch this should be good to go.

@malikrafsan
Copy link
Author

Thank you so much for your review @datomo ! But I think we need to merge this MR first, as this UI MR is introducing breaking changes on the icon and it dependent to this DB MR

polypheny/Polypheny-DB#485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants