WIP workspace pin and move requests #48
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ids1024
force-pushed
the
workspace-pin-move
branch
from
7c91e3f to
666772d
Compare
Yeah, agreeing with this. Either way the new methods seem fine. |
ids1024
force-pushed
the
workspace-pin-move
branch
from
666772d to
8d46a2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workspace pinning, as needed for pop-os/cosmic-workspaces-epoch#108.
That may not be very useful without a way to move workspaces. Particularly as pinned workspaces are moved automatically between outputs. So that is also added here.
Moving workspaces takes a
axisargument, so it can handle two or more dimensionalcoordinates. The assumption (I still need to add docs here) is that the coordinates of workspaces on other dimensions would be unchanged. Though the upstream protocol is intentionally vague enough that this won't suit all uses. It could instead assume only one axis.Now that ext-workspace-v1 exists, cosmic-workspace should probably be replaced with a v2 protocol that extends the upstream on, or turned into an extension protocol as was done with toplevel handles. If the latter isn't too awkward, that would help with migration of workspaces and screencopy.
Needs compositor and client implementation.