Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Wrap moveConnectable from terminal bus breaker view. #654

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[WIP] Wrap moveConnectable from terminal bus breaker view. #654

wants to merge 3 commits into from

Conversation

EtienneLt
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

@EtienneLt EtienneLt changed the title Wrap moveConnectable from terminal bus breaker view. [WIP] Wrap moveConnectable from terminal bus breaker view. Sep 25, 2023
@marota marota mentioned this pull request Sep 26, 2023
Merged
@EtienneLt EtienneLt mentioned this pull request Nov 3, 2023
Open
geofjamg
geofjamg requested changes Dec 11, 2023
View reviewed changes
Copy link
Member

@geofjamg geofjamg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should before this PR fix core to handle correctly regulating terminal and slack terminal relocation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geofjamg geofjamg geofjamg requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@tschuppr tschuppr

Labels
status: conflict with main status: does not compile status: ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EtienneLt @geofjamg @tschuppr @obrix