Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update visual regression snapshots #3273

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Update visual regression snapshots #3273

merged 3 commits into from
Jan 16, 2025

Conversation

khiga8
Copy link
Contributor

@khiga8 khiga8 commented Jan 16, 2025

What are you trying to accomplish?

This PR updates 900+ visual regression image snapshots.

In newly opened PRs, I'm getting 900+ image snapshot changes despite no obvious visual changes. It's really hard to compare diffs in this PR (it freezes up my browser), so I've opened a smaller PR so you can compare the snapshots there (#3274).

Its unclear to me what is causing this sudden change. The one suspicious PR that came to mind is the very recently merged #3271, which upgrades the Playwright version to 1.49.1 (in addition to introducing ARIA screenshots). But if this PR were the cause, these snapshots should have been updated in that PR...
As a test, I reverted the playwright change in #3275, but I still see the same 900+ changes which seems to indicate these snapshots would have been generated regardless of the playwright bump... This points to something else changing an causing this... but I'm unsure what.

I suggest we merge this if it's going to block other PRs.

Integration

List the issues that this change affects.

Closes # (type the GitHub issue number after #)

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.
  • No new axe scan violation - This change does not introduce any new axe scan violations.
  • New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Copy link

changeset-bot bot commented Jan 16, 2025

⚠️ No Changeset found

Latest commit: 693df74

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

⚠️ Visual or ARIA snapshot differences found

Our visual and ARIA snapshot tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review differences

@khiga8 khiga8 changed the title See if this triggers a trillion snapshot changes Update snapshots Jan 16, 2025
@khiga8 khiga8 changed the title Update snapshots Update visual regression snapshots Jan 16, 2025
@khiga8 khiga8 marked this pull request as ready for review January 16, 2025 21:58
@khiga8 khiga8 requested review from a team as code owners January 16, 2025 21:58
@camertron camertron merged commit be5c367 into main Jan 16, 2025
32 of 34 checks passed
@camertron camertron deleted the kh-test-snapshot-2 branch January 16, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants